From: Joe Lawrence <joe.lawrence@stratus.com>
To: <linux-kernel@vger.kernel.org>
Cc: <tj@kernel.org>, <paulmck@linux.vnet.ibm.com>, <jiri@resnulli.us>,
Joe Lawrence <joe.lawrence@stratus.com>, <stable@vger.kernel.org>
Subject: [PATCH v2 1/2] workqueue: add quiescent state between work items
Date: Sun, 5 Oct 2014 13:24:21 -0400 [thread overview]
Message-ID: <1412529862-17954-2-git-send-email-joe.lawrence@stratus.com> (raw)
In-Reply-To: <1412529862-17954-1-git-send-email-joe.lawrence@stratus.com>
Similar to the stop_machine deadlock scenario on !PREEMPT kernels
addressed in b22ce2785d97 "workqueue: cond_resched() after processing
each work item", kworker threads requeueing back-to-back with zero jiffy
delay can stall RCU. The cond_resched call introduced in that fix will
yield only iff there are other higher priority tasks to run, so force a
quiescent RCU state between work items.
Signed-off-by: Joe Lawrence <joe.lawrence@stratus.com>
Link: https://lkml.kernel.org/r/20140926105227.01325697@jlaw-desktop.mno.stratus.com
Link: https://lkml.kernel.org/r/20140929115445.40221d8e@jlaw-desktop.mno.stratus.com
Fixes: b22ce2785d97 ("workqueue: cond_resched() after processing each work item")
Cc: <stable@vger.kernel.org>
---
kernel/workqueue.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 5dbe22a..345bec9 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -2043,8 +2043,10 @@ __acquires(&pool->lock)
* kernels, where a requeueing work item waiting for something to
* happen could deadlock with stop_machine as such work item could
* indefinitely requeue itself while all other CPUs are trapped in
- * stop_machine.
+ * stop_machine. At the same time, report a quiescent RCU state so
+ * the same condition doesn't freeze RCU.
*/
+ rcu_note_voluntary_context_switch(current);
cond_resched();
spin_lock_irq(&pool->lock);
--
1.7.10.4
next prev parent reply other threads:[~2014-10-05 17:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-05 17:24 [PATCH v2 0/2] workqueue: add RCU quiescent state between items Joe Lawrence
2014-10-05 17:24 ` Joe Lawrence [this message]
2014-10-05 19:21 ` [PATCH v2 1/2] workqueue: add quiescent state between work items Tejun Heo
2014-10-05 19:47 ` Tejun Heo
2014-10-06 4:21 ` Paul E. McKenney
2014-10-07 7:29 ` Jiri Pirko
2014-10-07 13:43 ` Paul E. McKenney
2014-10-07 17:45 ` Joe Lawrence
2014-10-08 3:24 ` Paul E. McKenney
2014-10-08 11:54 ` Jiri Pirko
2014-10-08 12:19 ` Paul E. McKenney
2014-10-05 17:24 ` [PATCH v2 2/2] workqueue: use cond_resched_rcu_qs macro Joe Lawrence
2014-10-05 18:47 ` Paul E. McKenney
2014-10-05 19:48 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412529862-17954-2-git-send-email-joe.lawrence@stratus.com \
--to=joe.lawrence@stratus.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®