From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752324AbaJFDdT (ORCPT ); Sun, 5 Oct 2014 23:33:19 -0400 Received: from smtprelay0230.hostedemail.com ([216.40.44.230]:34598 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751859AbaJFDdS (ORCPT ); Sun, 5 Oct 2014 23:33:18 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:967:973:988:989:1260:1261:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2525:2553:2561:2564:2682:2685:2693:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3291:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6691:7652:7903:8985:9025:10004:10400:10848:11232:11658:11914:12043:12296:12517:12519:12740:13069:13161:13229:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: glass55_399916892bc11 X-Filterd-Recvd-Size: 2043 Message-ID: <1412566394.2916.10.camel@joe-AO725> Subject: Re: [PATCH] seq_file: Fix seq_putc() to be consistent with seq_puts() From: Joe Perches To: Al Viro Cc: Petr Mladek , Steven Rostedt , LKML , Andrew Morton , Linus Torvalds Date: Sun, 05 Oct 2014 20:33:14 -0700 In-Reply-To: <1412006881.4302.29.camel@joe-AO725> References: <20140926143721.52206f95@gandalf.local.home> <20140929144121.GA30562@pathway.suse.cz> <20140929154711.GF7996@ZenIV.linux.org.uk> <1412006881.4302.29.camel@joe-AO725> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2014-09-29 at 09:08 -0700, Joe Perches wrote: > On Mon, 2014-09-29 at 16:47 +0100, Al Viro wrote: > > On Mon, Sep 29, 2014 at 04:41:22PM +0200, Petr Mladek wrote: > > > Hmm, this inconsistency seems to be in more functions. I would divide > > > it into three categories: > [] > > No. _Any_ caller that decides to report that error to its caller is fucking > > broken. We had some cases like that. > [] > > And let's make seq_printf and friends return void. Any breakage we miss > > on grep will be caught by compiler. Enough is enough. > > https://lkml.org/lkml/2013/12/11/8 Hey Al, if you really want this to happen there are a couple hundred uses of the return value that could be inspected/converted. I've cc'd you a couple times now on a few patches that start that conversion. If you're serious about changing the return type for the next release, it'd be useful if you'd ack/nack the approach. https://lkml.org/lkml/2014/9/29/709