From: Joe Perches <joe@perches.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips <linux-mips@linux-mips.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mips: Convert pr_warning to pr_warn
Date: Mon, 06 Oct 2014 05:54:22 -0700 [thread overview]
Message-ID: <1412600062.2916.19.camel@joe-AO725> (raw)
In-Reply-To: <20141006124915.GA29036@linux-mips.org>
On Mon, 2014-10-06 at 14:49 +0200, Ralf Baechle wrote:
> On Sat, Oct 04, 2014 at 09:50:42AM -0700, Joe Perches wrote:
>
> > Use the much more common pr_warn instead of pr_warning
> > with the goal of removing pr_warning eventually.
>
> While I agree that only one of pr_warn and pr_warning deserves to live
> picking pr_warning introduces another logic inconsistency - for each
> pr_<foo> function there is a KERN_<FOO> severity symbol. And that in
> this case is named KERN_WARNING, there's no KERN_WARN.
Yes, I know. It's a consistency thing that can really
only be resolved one step at a time.
Most everything else uses _warn (dev_warn, netdev_warn,
etc...) so it'd be good to get pr_warn done too.
cheers, Joe
prev parent reply other threads:[~2014-10-06 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-04 16:50 Joe Perches
2014-10-06 12:49 ` Ralf Baechle
2014-10-06 12:54 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412600062.2916.19.camel@joe-AO725 \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®