From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753091AbaJFQNj (ORCPT ); Mon, 6 Oct 2014 12:13:39 -0400 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:45080 "EHLO e06smtp16.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752846AbaJFQN2 (ORCPT ); Mon, 6 Oct 2014 12:13:28 -0400 From: Alexander Yarygin To: linux-kernel@vger.kernel.org Cc: Alexander Yarygin , Arnaldo Carvalho de Melo , Christian Borntraeger , David Ahern , Ingo Molnar , Jiri Olsa , Paul Mackerras , Peter Zijlstra , Arnaldo Carvalho de Melo Subject: [PATCH] perf kvm stat record: print kvm specific --help output Date: Mon, 6 Oct 2014 20:13:18 +0400 Message-Id: <1412611998-8690-2-git-send-email-yarygin@linux.vnet.ibm.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1412611998-8690-1-git-send-email-yarygin@linux.vnet.ibm.com> References: <1412611998-8690-1-git-send-email-yarygin@linux.vnet.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14100616-3548-0000-0000-000001C574C7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The 'perf kvm stat record' tool is an alias of 'perf record' with predefined kvm related options. All options that passed to 'perf kvm stat record' are processed by the 'perf record' tool. So, 'perf kvm stat record --help' prints help of usage for the 'perf record' command. There are a few options useful for 'perf kvm stat record', the rest either break kvm related output or don't change it. Let's print safe for 'perf kvm stat record' options in addition to general 'perf record' --help output. Signed-off-by: Alexander Yarygin Cc: Arnaldo Carvalho de Melo Cc: Christian Borntraeger Cc: David Ahern Cc: Ingo Molnar Cc: Jiri Olsa Cc: Paul Mackerras Cc: Peter Zijlstra --- tools/perf/builtin-kvm.c | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c index 43367eb..0c169d7 100644 --- a/tools/perf/builtin-kvm.c +++ b/tools/perf/builtin-kvm.c @@ -1138,6 +1138,40 @@ exit: _p; \ }) +static void print_record_help(void) +{ + fprintf(stderr, "\n usage: perf kvm stat record []\n\n"); + + fprintf(stderr, " -p, --pid record events on existing process id\n"); + fprintf(stderr, " -t, --tid record events on existing thread id\n"); + fprintf(stderr, " -r, --realtime collect data with this RT SCHED_FIFO priority\n"); + fprintf(stderr, " --no-buffering collect data without buffering\n"); + fprintf(stderr, " -a, --all-cpus system-wide collection from all CPUs\n"); + fprintf(stderr, " -C, --cpu list of cpus to monitor\n"); + fprintf(stderr, " -c, --count event period to sample\n"); + fprintf(stderr, " -o, --output output file name\n"); + fprintf(stderr, " -i, --no-inherit child tasks do not inherit counters\n"); + fprintf(stderr, " -m, --mmap-pages \n"); + fprintf(stderr, " number of mmap data pages\n"); + fprintf(stderr, " -v, --verbose be more verbose (show counter open errors, etc)\n"); + fprintf(stderr, " -q, --quiet don't print any message\n"); + fprintf(stderr, " -D, --delay ms to wait before starting measurement after program start\n"); + fprintf(stderr, " -u, --uid user to profile\n"); + fprintf(stderr, " --per-thread use per-thread mmaps\n"); + + fprintf(stderr, "\nOtherwise, it is the alias of 'perf record:'\n"); +} + +static bool is_help_option(int argc, const char **argv) +{ + int i; + + for (i = 0; i < argc; i++) + if (!strcmp(argv[i], "--help") || !strcmp(argv[i], "-h")) + return true; + return false; +} + static int kvm_events_record(struct perf_kvm_stat *kvm, int argc, const char **argv) { @@ -1150,6 +1184,10 @@ kvm_events_record(struct perf_kvm_stat *kvm, int argc, const char **argv) "-c", "1", }; const char * const *events_tp; + + if (argc == 1 || (argc > 1 && is_help_option(argc, argv))) + print_record_help(); + events_tp_size = 0; for (events_tp = kvm_events_tp; *events_tp; events_tp++) -- 1.9.1