From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751970AbcIIXhc (ORCPT ); Fri, 9 Sep 2016 19:37:32 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:33250 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751174AbcIIXh3 (ORCPT ); Fri, 9 Sep 2016 19:37:29 -0400 Subject: Re: [Nbd] [RESEND][PATCH 0/5] nbd improvements To: Josef Bacik , Wouter Verhelst References: <1473369130-22986-1-git-send-email-jbacik@fb.com> <20160909200203.phhvodsfs7ymukfp@grep.be> <3536bb1d-623d-8533-1584-0040207a6c3d@fb.com> <20160909205535.xfl3py76z6zedejt@grep.be> Cc: linux-block@vger.kernel.org, mpa@pengutronix.de, kernel-team@fb.com, nbd-general@lists.sourceforge.net, linux-kernel@vger.kernel.org From: Jens Axboe Message-ID: <14127c86-f6c5-22e6-ae14-c2b9a6395372@kernel.dk> Date: Fri, 9 Sep 2016 17:37:21 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/09/2016 05:00 PM, Josef Bacik wrote: >> Right. Alternatively, you could perhaps make it so that the lost >> connection is removed, unack'd requests on that connection are resent, >> and the session moves on with one less connection (unless the lost >> connection is the last one, in which case we die as before). That might >> be too much work and not worth it though. > > Yeah I wasn't sure if we could just randomly remove hw queue's in blk mq > while the device is still up. If that is in fact easy to do then I'm in > favor of trucking along with less connections than we originally had, > otherwise I think it'll be too big of a pain. Also some users (Facebook > in this case) would rather the whole thing fail so we can figure out > what went wrong rather than suddenly going at a degraded performance. We can do that online. We do that for CPU hotplug/unplug events, and we also expose that functionality to drivers through blk_mq_update_nr_hw_queues(). So yes, should be trivial to support from nbd. -- Jens Axboe