mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Martin Kepplinger <martink@posteo.de>
To: gregkh@linuxfoundation.org
Cc: arnd@arndb.de, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org,
	Martin Kepplinger <martink@posteo.de>
Subject: [PATCH] char: documentation: more useful information about misc device
Date: Thu,  9 Oct 2014 18:37:35 +0200	[thread overview]
Message-ID: <1412872655-11403-1-git-send-email-martink@posteo.de> (raw)
In-Reply-To: <20141009155020.GB27912@kroah.com>

This might prevent code duplication in the future.

Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
This is a suggestion for a place to put this information. I think this
makes sense but there might be a more appropriate place elsewhere.

 drivers/char/misc.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index ffa97d2..6a3d15b 100644
--- a/drivers/char/misc.c
+++ b/drivers/char/misc.c
@@ -171,6 +171,10 @@ static const struct file_operations misc_fops = {
  *	The structure passed is linked into the kernel and may not be
  *	destroyed until it has been unregistered.
  *
+ *	If struct miscdevice's fops contain an implementation of open()
+ *	the struct file's private data will be a pointer back to
+ *	struct miscdevice.
+ *
  *	A zero is returned on success and a negative errno code for
  *	failure.
  */
-- 
1.7.10.4


  reply	other threads:[~2014-10-09 16:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-08  8:47 [PATCH] misc: always assign miscdevice to file->private_data in open() Martin Kepplinger
2014-10-08 13:43 ` Greg KH
2014-10-09 13:10   ` Martin Kepplinger
2014-10-09 15:50     ` Greg KH
2014-10-09 16:37       ` Martin Kepplinger [this message]
2014-10-16 11:08       ` Martin Kepplinger
2014-10-18 23:12       ` Martin Kepplinger
2014-10-19  0:30         ` [PATCH 1/3] " Martin Kepplinger
2014-10-19  0:30           ` [PATCH 2/3] fbdev: pxa3xx-gcu: remove redundant implementation of open() Martin Kepplinger
2014-10-19  0:31           ` [PATCH 3/3] lguest: force file->private_data to be NULL on open() Martin Kepplinger
2014-10-20 13:41             ` Martin Kepplinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412872655-11403-1-git-send-email-martink@posteo.de \
    --to=martink@posteo.de \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®