From: Joe Perches <joe@perches.com>
To: Lars Melin <larsm17@gmail.com>
Cc: Jonas Brunsgaard <jonas.brunsgaard@gmail.com>,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: atm: fix codestyle issues in
Date: Sat, 11 Oct 2014 10:08:30 -0700 [thread overview]
Message-ID: <1413047310.16385.31.camel@joe-AO725> (raw)
In-Reply-To: <5439621C.20405@gmail.com>
On Sun, 2014-10-12 at 00:00 +0700, Lars Melin wrote:
> On 2014-10-11 23:02, Jonas Brunsgaard wrote:
> > Signed-off-by: Jonas Brunsgaard <jonas.brunsgaard@gmail.com>
[]
> > diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c
[ 15 KB of quoted stuff ]
> Read:
> https://www.kernel.org/doc/Documentation/CodingStyle
Besides needlessly quoting a large quantity of the
previous email, this is an unhelpful comment.
Point out what's wrong with the patch.
AFAICT, nothing in particular.
next prev parent reply other threads:[~2014-10-11 17:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 16:02 Jonas Brunsgaard
2014-10-11 17:00 ` Lars Melin
2014-10-11 17:08 ` Joe Perches [this message]
2014-10-11 17:28 ` Jonas Brunsgaard
2014-10-11 17:41 ` Lars Melin
2014-10-11 20:17 ` Greg KH
2014-10-11 22:35 ` Jonas Brunsgaard
2014-10-11 21:40 ` [PATCH v2] usb: atm: fix style issues Jonas Brunsgaard
2014-10-13 1:32 ` Greg KH
2014-10-13 16:08 ` Jonas Brunsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413047310.16385.31.camel@joe-AO725 \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonas.brunsgaard@gmail.com \
--cc=larsm17@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®