From: Joe Perches <joe@perches.com>
To: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com>
Cc: pdeschrijver@nvidia.com, rmk+kernel@arm.linux.org.uk,
swarren@nvidia.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] init: calibrate: fix style issues
Date: Sat, 11 Oct 2014 10:36:16 -0700 [thread overview]
Message-ID: <1413048976.16385.37.camel@joe-AO725> (raw)
In-Reply-To: <543967AC.6070507@gmail.com>
On Sat, 2014-10-11 at 19:23 +0200, Rasmus Wriedt Larsen wrote:
> On 11/10/14 18:40, Joe Perches wrote:
> > On Sat, 2014-10-11 at 18:31 +0200, Rasmus Wriedt Larsen wrote:
> >> * fix multiple quoted string split across lines style issues
> >> * change printk(KERN_NOTICE to pr_notice
> >> * insert spaces after , in function call
> > []
> >> diff --git a/init/calibrate.c b/init/calibrate.c
> > []
> >> @@ -160,9 +158,7 @@ static unsigned long calibrate_delay_direct(void)
> >>
> >> }
> >>
> >> - printk(KERN_NOTICE "calibrate_delay_direct() failed to get a good "
> >> - "estimate for loops_per_jiffy.\nProbably due to long platform "
> >> - "interrupts. Consider using \"lpj=\" boot option.\n");
> >> + pr_notice("calibrate_delay_direct() failed to get a good estimate for loops_per_jiffy.\nProbably due to long platform interrupts. Consider using \"lpj=\" boot option.\n");
> >
> > This would be better on 2 lines:
> > pr_notice("calibrate_delay_direct() failed to get a good estimate for loops_per_jiffy.\n"
> > "Probably due to long platform interrupts. Consider using \"lpj=\" boot option.\n");
>
> Yes, indeed it would. (will fix in upcoming patch)
>
> > The grammar is poor though and this
> > could be better phrased.
>
> Any suggestions? I don't see anything in particular (but English is not my
> native language either)
I'd suggest something on a single line like:
pr_notice("%s: failed to reasonably estimate loops_per_jiffy (long platform interrupts?) - perhaps use boot option 'lpj='\n",
__func__);
I prefer complete individual messages and don't
mind longer dmesg message lines.
next prev parent reply other threads:[~2014-10-11 17:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 16:31 Rasmus Wriedt Larsen
2014-10-11 16:40 ` Joe Perches
2014-10-11 17:23 ` Rasmus Wriedt Larsen
2014-10-11 17:36 ` Joe Perches [this message]
2014-10-13 10:12 ` [PATCH v2] " Rasmus Wriedt Larsen
2014-12-08 20:56 ` Rasmus Wriedt Larsen
2014-12-09 0:24 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413048976.16385.37.camel@joe-AO725 \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=rasmuswriedtlarsen@gmail.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®