From: Joe Perches <joe@perches.com>
To: Jia He <hejianet@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: Fix coding style space related ERROR problems
Date: Mon, 13 Oct 2014 02:13:05 -0700 [thread overview]
Message-ID: <1413191585.1287.8.camel@joe-AO725> (raw)
In-Reply-To: <1413190026-5749-1-git-send-email-hejianet@gmail.com>
On Mon, 2014-10-13 at 16:47 +0800, Jia He wrote:
> This fixes space related ERROR reports by checkpatch.pl
> Generated by $ git ls-files "drivers/staging/rtl8188eu/*.[ch]" | \
> xargs ./scripts/checkpatch.pl -f --fix-inplace --strict --types=SPACING
checkpatch isn't perfect.
Always verify the output before submitting automated changes.
> diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c
[]
> @@ -772,7 +772,7 @@ static s32 xmitframe_swencrypt(struct adapter *padapter, struct xmit_frame *pxmi
> return _SUCCESS;
> }
>
> -s32 rtw_make_wlanhdr (struct adapter *padapter , u8 *hdr, struct pkt_attrib *pattrib)
> +s32 rtw_make_wlanhdr(struct adapter *padapter , u8 *hdr, struct pkt_attrib *pattrib)
The space after padapter should be removed.
> diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/hal/bb_cfg.c
> @@ -552,7 +552,7 @@ static void store_pwrindex_offset(struct adapter *Adapter, u32 regaddr, u32 bitm
> }
> }
>
> -static void rtl_addr_delay(struct adapter *adapt, u32 addr, u32 bit_mask ,u32 data)
> +static void rtl_addr_delay(struct adapter *adapt, u32 addr, u32 bit_mask , u32 data)
likewise, the space after bit_mask too
> diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
[]
> @@ -2059,7 +2059,7 @@ static int wpa_supplicant_ioctl(struct net_device *dev, struct iw_point *p)
> struct ieee_param *param;
> uint ret = 0;
>
> - if (p->length < sizeof(struct ieee_param) || !p->pointer) {
> + if (p->length < sizeof(struct ieee_param)|| !p->pointer) {
checkpatch defect, nothing wrong with original.
next prev parent reply other threads:[~2014-10-13 9:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 8:47 Jia He
2014-10-13 9:13 ` Joe Perches [this message]
2014-10-14 3:28 ` [PATCHv2] " Jia He
2014-10-14 4:48 ` Jia He
2014-10-17 5:31 ` hejianet
2014-10-17 5:54 ` Dan Carpenter
2014-10-17 8:06 ` Greg Kroah-Hartman
2014-10-29 8:45 ` Greg Kroah-Hartman
2014-10-30 15:21 ` [PATCHv3] " Jia He
2014-10-30 15:29 ` Greg Kroah-Hartman
2014-11-03 4:47 ` hejianet
2014-10-31 2:07 ` [PATCH] " Jia He
2014-11-04 0:25 ` Greg Kroah-Hartman
2014-11-04 1:13 ` hejianet
2014-11-04 1:39 ` Jia He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413191585.1287.8.camel@joe-AO725 \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hejianet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®