mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Antonios Motakis <a.motakis@virtualopensystems.com>
To: kvmarm@lists.cs.columbia.edu, iommu@lists.linux-foundation.org,
	alex.williamson@redhat.com
Cc: will.deacon@arm.com, tech@virtualopensystems.com,
	christoffer.dall@linaro.org, eric.auger@linaro.org,
	kim.phillips@freescale.com, marc.zyngier@arm.com,
	Antonios Motakis <a.motakis@virtualopensystems.com>,
	kvm@vger.kernel.org (open list:VFIO DRIVER),
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v8 06/18] vfio/platform: return info for bound device
Date: Mon, 13 Oct 2014 15:10:13 +0200	[thread overview]
Message-ID: <1413205825-6370-7-git-send-email-a.motakis@virtualopensystems.com> (raw)
In-Reply-To: <1413205825-6370-1-git-send-email-a.motakis@virtualopensystems.com>

A VFIO userspace driver will start by opening the VFIO device
that corresponds to an IOMMU group, and will use the ioctl interface
to get the basic device info, such as number of memory regions and
interrupts, and their properties. This patch enables the
VFIO_DEVICE_GET_INFO ioctl call.

Signed-off-by: Antonios Motakis <a.motakis@virtualopensystems.com>
---
 drivers/vfio/platform/vfio_platform_common.c | 23 ++++++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)

diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
index 13808d0..1e4073f 100644
--- a/drivers/vfio/platform/vfio_platform_common.c
+++ b/drivers/vfio/platform/vfio_platform_common.c
@@ -43,10 +43,27 @@ static int vfio_platform_open(void *device_data)
 static long vfio_platform_ioctl(void *device_data,
 			   unsigned int cmd, unsigned long arg)
 {
-	if (cmd == VFIO_DEVICE_GET_INFO)
-		return -EINVAL;
+	struct vfio_platform_device *vdev = device_data;
+	unsigned long minsz;
+
+	if (cmd == VFIO_DEVICE_GET_INFO) {
+		struct vfio_device_info info;
+
+		minsz = offsetofend(struct vfio_device_info, num_irqs);
+
+		if (copy_from_user(&info, (void __user *)arg, minsz))
+			return -EFAULT;
+
+		if (info.argsz < minsz)
+			return -EINVAL;
+
+		info.flags = vdev->flags;
+		info.num_regions = 0;
+		info.num_irqs = 0;
+
+		return copy_to_user((void __user *)arg, &info, minsz);
 
-	else if (cmd == VFIO_DEVICE_GET_REGION_INFO)
+	} else if (cmd == VFIO_DEVICE_GET_REGION_INFO)
 		return -EINVAL;
 
 	else if (cmd == VFIO_DEVICE_GET_IRQ_INFO)
-- 
2.1.1


  parent reply	other threads:[~2014-10-13 13:11 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1413205825-6370-1-git-send-email-a.motakis@virtualopensystems.com>
2014-10-13 13:10 ` [PATCH v8 01/18] vfio/platform: initial skeleton of VFIO support for platform devices Antonios Motakis
2014-10-13 13:10 ` [PATCH v8 02/18] vfio: platform: probe to devices on the platform bus Antonios Motakis
2014-10-21 16:17   ` Alex Williamson
     [not found]     ` <54468BDA.6050606@linaro.org>
2014-10-22 13:53       ` Antonios Motakis
2014-10-13 13:10 ` [PATCH v8 03/18] vfio: platform: add the VFIO PLATFORM module to Kconfig Antonios Motakis
2014-10-13 13:10 ` [PATCH v8 04/18] vfio: amba: VFIO support for AMBA devices Antonios Motakis
2014-10-13 13:10 ` [PATCH v8 05/18] vfio: amba: add the VFIO for AMBA devices module to Kconfig Antonios Motakis
2014-10-13 13:10 ` Antonios Motakis [this message]
2014-10-13 13:10 ` [PATCH v8 07/18] vfio/platform: return info for device memory mapped IO regions Antonios Motakis
2014-10-21 16:34   ` Alex Williamson
2014-10-21 18:18     ` Bharat.Bhushan
2014-10-21 18:57       ` Alex Williamson
2014-10-22 13:54     ` Antonios Motakis
2014-10-22 16:46       ` Alex Williamson
2014-10-22 17:53         ` Antonios Motakis
2014-10-13 13:10 ` [PATCH v8 08/18] vfio/platform: read and write support for the device fd Antonios Motakis
2014-10-13 13:10 ` [PATCH v8 09/18] vfio/platform: support MMAP of MMIO regions Antonios Motakis
2014-10-21 16:51   ` Alex Williamson
2014-10-22 13:55     ` Antonios Motakis
2014-10-22 16:56       ` Alex Williamson
2014-10-13 13:10 ` [PATCH v8 10/18] vfio/platform: return IRQ info Antonios Motakis
2014-10-13 13:10 ` [PATCH v8 11/18] vfio/platform: initial interrupts support code Antonios Motakis
2014-10-13 13:10 ` [PATCH v8 12/18] vfio/platform: trigger an interrupt via eventfd Antonios Motakis
2014-10-13 13:10 ` [PATCH v8 13/18] vfio/platform: support for maskable and automasked interrupts Antonios Motakis
2014-10-21 17:47   ` Alex Williamson
2014-10-22 13:55     ` Antonios Motakis
2014-10-13 13:10 ` [PATCH v8 14/18] vfio: move eventfd support code for VFIO_PCI to a separate file Antonios Motakis
2014-10-21 17:55   ` Alex Williamson
2014-10-22 13:56     ` Antonios Motakis
2014-10-13 13:10 ` [PATCH v8 15/18] vfio: add local lock in virqfd instead of depending on VFIO PCI Antonios Motakis
2014-10-13 13:10 ` [PATCH v8 16/18] vfio: pass an opaque pointer on virqfd initialization Antonios Motakis
2014-10-13 13:10 ` [PATCH v8 17/18] vfio: initialize the virqfd workqueue in VFIO generic code Antonios Motakis
2014-10-13 13:10 ` [PATCH v8 18/18] vfio/platform: implement IRQ masking/unmasking via an eventfd Antonios Motakis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413205825-6370-7-git-send-email-a.motakis@virtualopensystems.com \
    --to=a.motakis@virtualopensystems.com \
    --cc=alex.williamson@redhat.com \
    --cc=christoffer.dall@linaro.org \
    --cc=eric.auger@linaro.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=kim.phillips@freescale.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=tech@virtualopensystems.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®