From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Thomas Shao <huishao@microsoft.com>,
tglx@linutronix.de, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com,
kys@microsoft.com
Subject: Re: [PATCH 2/2] hyperv: Implement Time Synchronization using host time sample
Date: Tue, 14 Oct 2014 06:43:55 -0700 [thread overview]
Message-ID: <1413294235.3269.4.camel@joe-AO725> (raw)
In-Reply-To: <20141014111915.GV23154@mwanda>
On Tue, 2014-10-14 at 14:19 +0300, Dan Carpenter wrote:
> I had a couple small style nits.
>
> On Tue, Oct 14, 2014 at 04:11:18AM -0700, Thomas Shao wrote:
> > diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c
> > index 3b9c9ef..1d8390c 100644
> > --- a/drivers/hv/hv_util.c
> > +++ b/drivers/hv/hv_util.c
> > @@ -51,11 +51,30 @@
> > #define HB_WS2008_MAJOR 1
> > #define HB_WS2008_VERSION (HB_WS2008_MAJOR << 16 | HB_MINOR)
> >
> > +#define TIMESAMPLE_INTERVAL 5000000000L /* 5s in nanosecond */
>
> If you wanted you could say:
>
> #define TIMESAMPLE_INTERVAL (5 * NSEC_PER_SEC)
ULL
next prev parent reply other threads:[~2014-10-14 13:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 11:11 Thomas Shao
2014-10-14 11:19 ` Dan Carpenter
2014-10-14 12:50 ` Thomas Shao
2014-10-14 13:10 ` Dan Carpenter
2014-10-14 13:13 ` Thomas Shao
2014-10-14 13:16 ` Mike Surcouf
2014-10-14 14:00 ` Thomas Shao
2014-10-14 16:46 ` Mike Surcouf
2014-10-14 14:21 ` Richard Cochran
2014-10-14 13:43 ` Joe Perches [this message]
2014-10-14 11:54 ` Richard Cochran
2014-10-14 13:04 ` Thomas Shao
2014-10-14 13:19 ` Richard Cochran
2014-10-14 14:08 ` Thomas Shao
2014-10-14 13:25 ` Richard Cochran
2014-10-14 14:12 ` Thomas Shao
2014-10-14 14:14 ` Mike Surcouf
2014-10-14 14:33 ` Richard Cochran
2014-10-14 15:00 ` Victor Miasnikov
2014-10-14 16:30 ` Richard Cochran
2014-10-14 14:25 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413294235.3269.4.camel@joe-AO725 \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=huishao@microsoft.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®