mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Hurley <peter@hurleysoftware.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jiri Slaby <jslaby@suse.cz>,
	One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
	Peter Hurley <peter@hurleysoftware.com>
Subject: [PATCH -next 05/10] tty: Document defunct ASYNC_* bits in uapi header
Date: Thu, 16 Oct 2014 16:54:22 -0400	[thread overview]
Message-ID: <1413492867-20679-6-git-send-email-peter@hurleysoftware.com> (raw)
In-Reply-To: <1413492867-20679-1-git-send-email-peter@hurleysoftware.com>

Note the serial_struct flags for which the kernel ignores and performs
no action. The flags cannot be removed since they form part of the
userspace interface via the TIOCSSERIAL/TIOCGSERIAL ioctls.

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
---
 include/uapi/linux/tty_flags.h | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/include/uapi/linux/tty_flags.h b/include/uapi/linux/tty_flags.h
index 7b516f7..4e021e3 100644
--- a/include/uapi/linux/tty_flags.h
+++ b/include/uapi/linux/tty_flags.h
@@ -8,6 +8,7 @@
  * Define ASYNCB_* for convenient use with {test,set,clear}_bit.
  *
  * Bits [0..ASYNCB_LAST_USER] are userspace defined/visible/changeable
+ * [x] in the bit comments indicates the flag is defunct and no longer used.
  */
 #define ASYNCB_HUP_NOTIFY	 0 /* Notify getty on hangups and closes
 				    * on the callout port */
@@ -19,15 +20,15 @@
 #define ASYNCB_SKIP_TEST	 6 /* Skip UART test during autoconfiguration */
 #define ASYNCB_AUTO_IRQ		 7 /* Do automatic IRQ during
 				    * autoconfiguration */
-#define ASYNCB_SESSION_LOCKOUT	 8 /* Lock out cua opens based on session */
-#define ASYNCB_PGRP_LOCKOUT	 9 /* Lock out cua opens based on pgrp */
-#define ASYNCB_CALLOUT_NOHUP	10 /* Don't do hangups for cua device */
+#define ASYNCB_SESSION_LOCKOUT	 8 /* [x] Lock out cua opens based on session */
+#define ASYNCB_PGRP_LOCKOUT	 9 /* [x] Lock out cua opens based on pgrp */
+#define ASYNCB_CALLOUT_NOHUP	10 /* [x] Don't do hangups for cua device */
 #define ASYNCB_HARDPPS_CD	11 /* Call hardpps when CD goes high  */
 #define ASYNCB_SPD_SHI		12 /* Use 230400 instead of 38400 bps */
 #define ASYNCB_LOW_LATENCY	13 /* Request low latency behaviour */
 #define ASYNCB_BUGGY_UART	14 /* This is a buggy UART, skip some safety
 				    * checks.  Note: can be dangerous! */
-#define ASYNCB_AUTOPROBE	15 /* Port was autoprobed by PCI or PNP code */
+#define ASYNCB_AUTOPROBE	15 /* [x] Port was autoprobed by PCI/PNP code */
 #define ASYNCB_MAGIC_MULTIPLIER	16 /* Use special CLK or divisor */
 #define ASYNCB_LAST_USER	16
 
-- 
2.1.1


  parent reply	other threads:[~2014-10-16 20:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-16 20:54 [PATCH -next 00/10] serial core fixes Peter Hurley
2014-10-16 20:54 ` [PATCH -next 01/10] serial: Refactor uart_flush_buffer() from uart_close() Peter Hurley
2014-10-16 20:54 ` [PATCH -next 02/10] serial: core: Flush ldisc after dropping port mutex in uart_close() Peter Hurley
2014-10-16 20:54 ` [PATCH -next 03/10] serial: Fix locking for uart driver set_termios() method Peter Hurley
2014-10-16 20:54 ` [PATCH -next 04/10] tty,serial: Unify UPF_* and ASYNC_* flag definitions Peter Hurley
2014-10-16 20:54 ` Peter Hurley [this message]
2014-10-17  8:46   ` [PATCH -next 05/10] tty: Document defunct ASYNC_* bits in uapi header Jiri Slaby
2014-10-17 12:44     ` Peter Hurley
2014-10-17 13:31       ` Jiri Slaby
2014-11-06  2:53         ` Greg Kroah-Hartman
2014-10-16 20:54 ` [PATCH -next 06/10] serial: core: Unwrap >80 char line in uart_close() Peter Hurley
2014-10-16 20:54 ` [PATCH -next 07/10] serial: core: Remove redundant timeout assignments Peter Hurley
2014-10-16 20:54 ` [PATCH -next 08/10] serial: core: Colocate crucial structure linkage Peter Hurley
2014-10-16 20:54 ` [PATCH -next 09/10] serial: core: Remove extra locking in uart_write() Peter Hurley
2014-10-16 20:54 ` [PATCH -next 10/10] serial: core: Fix port count when uart_open() errors Peter Hurley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413492867-20679-6-git-send-email-peter@hurleysoftware.com \
    --to=peter@hurleysoftware.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome