From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Paul Zimmerman <paulz@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 2/2] usb: dwc2: gadget: modify return statement
Date: Fri, 17 Oct 2014 10:14:03 +0530 [thread overview]
Message-ID: <1413521043-7587-2-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1413521043-7587-1-git-send-email-sudipm.mukherjee@gmail.com>
modified the function to have a single return statement at the end
instead of multiple return statement in the middle of the function
to improve the readability of the code.
This patch depends on the previous patch of the series.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/usb/dwc2/gadget.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 7f25527..e8a8fc7 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -2471,7 +2471,8 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep,
dir_in = (desc->bEndpointAddress & USB_ENDPOINT_DIR_MASK) ? 1 : 0;
if (dir_in != hs_ep->dir_in) {
dev_err(hsotg->dev, "%s: direction mismatch!\n", __func__);
- return -EINVAL;
+ ret = -EINVAL;
+ goto error1;
}
mps = usb_endpoint_maxp(desc);
@@ -2583,6 +2584,7 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep,
error:
spin_unlock_irqrestore(&hsotg->lock, flags);
+error1:
return ret;
}
--
1.8.1.2
next prev parent reply other threads:[~2014-10-17 4:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 4:44 [PATCH v3 1/2] usb: dwc2: gadget: sparse warning of context imbalance Sudip Mukherjee
2014-10-17 4:44 ` Sudip Mukherjee [this message]
2014-10-17 9:02 ` [PATCH v3 2/2] usb: dwc2: gadget: modify return statement David Laight
2014-10-17 10:03 ` Sudip Mukherjee
2014-10-17 18:10 ` Paul Zimmerman
2014-10-17 18:52 ` Paul Zimmerman
2014-10-17 18:50 ` [PATCH v3 1/2] usb: dwc2: gadget: sparse warning of context imbalance Paul Zimmerman
2014-10-17 18:52 ` Felipe Balbi
2014-10-17 19:05 ` Paul Zimmerman
2014-10-17 19:12 ` Felipe Balbi
2014-10-23 10:07 ` Sudip Mukherjee
2014-10-23 10:17 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413521043-7587-2-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=paulz@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®