mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Josh Wu <Josh.wu@atmel.com>, Jingoo Han <jg1.han@samsung.com>,
	Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
	Mark Brown <broonie@linaro.org>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Herve Codina <Herve.CODINA@celad.com>,
	Bo Shen <voice.shen@atmel.com>,
	Fabio Estevam <fabio.estevam@freescale.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Michael Grzeschik <m.grzeschik@pengutronix.de>,
	Josh Triplett <josh@joshtriplett.org>,
	Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
	Huang Shijie <shijie8@gmail.com>,
	Michael Opdenacker <michael.opdenacker@free-electrons.com>,
	Vinod Koul <vinod.koul@intel.com>
Subject: [PATCH 2/2] mtd: mxc_nand: use __iowrite32_copy for 32 bit copy
Date: Mon, 20 Oct 2014 21:36:13 +0530	[thread overview]
Message-ID: <1413821173-18347-2-git-send-email-vinod.koul@intel.com> (raw)
In-Reply-To: <1413821173-18347-1-git-send-email-vinod.koul@intel.com>

The driver was also using own method to do 32bit copy, turns out
we have a kernel API so use that instead

Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 drivers/mtd/nand/mxc_nand.c |   10 +++-------
 1 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
index dba262b..3794cd7 100644
--- a/drivers/mtd/nand/mxc_nand.c
+++ b/drivers/mtd/nand/mxc_nand.c
@@ -280,14 +280,10 @@ static void memcpy32_fromio(void *trg, const void __iomem  *src, size_t size)
 		*t++ = __raw_readl(s++);
 }
 
-static void memcpy32_toio(void __iomem *trg, const void *src, int size)
+static inline void memcpy32_toio(void __iomem *trg, const void *src, int size)
 {
-	int i;
-	u32 __iomem *t = trg;
-	const u32 *s = src;
-
-	for (i = 0; i < (size >> 2); i++)
-		__raw_writel(*s++, t++);
+	/* __iowrite32_copy use 32bit size values so divide by 4 */
+	__iowrite32_copy(trg, src, size/4);
 }
 
 static int check_int_v3(struct mxc_nand_host *host)
-- 
1.7.0.4


  reply	other threads:[~2014-10-20 16:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-20 16:06 [PATCH 1/2] mtd: atmel_nand: " Vinod Koul
2014-10-20 16:06 ` Vinod Koul [this message]
2014-11-05 22:29   ` [PATCH 2/2] mtd: mxc_nand: " Brian Norris
2014-10-21 10:03 ` [PATCH 1/2] mtd: atmel_nand: " Josh Wu
2014-10-21 10:20   ` [PATCH 1/2] mtd: atmel_nand: use __iowrite32_copy for 32 bitcopy Herve Codina
2014-10-21 10:35     ` Vinod Koul
2014-10-22  7:35       ` Josh Wu
2014-10-21 10:33   ` [PATCH 1/2] mtd: atmel_nand: use __iowrite32_copy for 32 bit copy Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413821173-18347-2-git-send-email-vinod.koul@intel.com \
    --to=vinod.koul@intel.com \
    --cc=Herve.CODINA@celad.com \
    --cc=Josh.wu@atmel.com \
    --cc=akpm@linux-foundation.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=broonie@linaro.org \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=fabio.estevam@freescale.com \
    --cc=jg1.han@samsung.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=m.grzeschik@pengutronix.de \
    --cc=michael.opdenacker@free-electrons.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=shijie8@gmail.com \
    --cc=voice.shen@atmel.com \
    --cc=yongjun_wei@trendmicro.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®