From: Joe Perches <joe@perches.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Andy Whitcroft <apw@canonical.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch false positive
Date: Tue, 21 Oct 2014 01:28:25 -0700 [thread overview]
Message-ID: <1413880105.12828.3.camel@perches.com> (raw)
In-Reply-To: <54461602.4000705@redhat.com>
On Tue, 2014-10-21 at 10:14 +0200, Hans de Goede wrote:
> Hi,
>
> Checkpatch gives the following warning:
>
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #31:
> new file mode 100644
>
> total: 0 errors, 1 warnings, 352 lines checked
>
> 0001-input-Add-new-sun4i-lradc-keys-driver.patch has style problems, please review.
>
> If any of these errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
> On a patch of mine, even though it updates MAINTAINERS properly, it would
> be nice if checkpatch would check for a hunk updating MAINTAINERS, and then
> would not issue this warning (note my perl-foo is way too weak to fix this
> myself).
>
> I've attached the patch triggering the warning.
Hi Hans.
It's not really fixable. Of course you are welcome to
try though.
Many patches are discrete and the entire series isn't
visible to a single MAINTAINERS update scan by checkpatch.
next parent reply other threads:[~2014-10-21 8:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <54461602.4000705@redhat.com>
2014-10-21 8:28 ` Joe Perches [this message]
2014-10-21 9:27 ` Hans de Goede
2015-07-16 10:55 Checkpatch: False positive Viresh Kumar
2015-07-16 15:35 ` Joe Perches
2015-07-16 15:43 ` Andy Whitcroft
2015-07-16 15:58 ` Joe Perches
2015-07-16 17:21 ` Andy Whitcroft
-- strict thread matches above, loose matches on Subject: below --
2010-08-11 16:35 checkpatch false positive Dave Jones
2010-03-17 11:00 Richard Kennedy
2010-03-17 11:53 ` Andy Whitcroft
2010-03-17 15:25 ` Joe Perches
2010-03-17 15:40 ` Richard Kennedy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413880105.12828.3.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome