From: Zhihui Zhang <zzhsuny@gmail.com>
To: tj@kernel.org, cl@linux-foundation.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] [percpu] Make the unit size of the first chunk the same as other chunks
Date: Sat, 25 Oct 2014 11:05:58 -0400 [thread overview]
Message-ID: <1414249558-6677-1-git-send-email-zzhsuny@gmail.com> (raw)
Since we have already allocated the full unit size for the first chunk, we might as well use
it so that the unit size are the same for all chunks. The page first chunk allocator already
has this effect because it allocates one page at a time.
Signed-off-by: Zhihui Zhang <zzhsuny@gmail.com>
---
mm/percpu.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/percpu.c b/mm/percpu.c
index 014bab6..7242360 100644
--- a/mm/percpu.c
+++ b/mm/percpu.c
@@ -1960,6 +1960,7 @@ int __init pcpu_embed_first_chunk(size_t reserved_size, size_t dyn_size,
return PTR_ERR(ai);
size_sum = ai->static_size + ai->reserved_size + ai->dyn_size;
+ ai->dyn_size += ai->unit_size - size_sum;
areas_size = PFN_ALIGN(ai->nr_groups * sizeof(void *));
areas = memblock_virt_alloc_nopanic(areas_size, 0);
@@ -2006,9 +2007,8 @@ int __init pcpu_embed_first_chunk(size_t reserved_size, size_t dyn_size,
free_fn(ptr, ai->unit_size);
continue;
}
- /* copy and return the unused part */
+ /* copy static data */
memcpy(ptr, __per_cpu_load, ai->static_size);
- free_fn(ptr + size_sum, ai->unit_size - size_sum);
}
}
@@ -2034,7 +2034,7 @@ int __init pcpu_embed_first_chunk(size_t reserved_size, size_t dyn_size,
}
pr_info("PERCPU: Embedded %zu pages/cpu @%p s%zu r%zu d%zu u%zu\n",
- PFN_DOWN(size_sum), base, ai->static_size, ai->reserved_size,
+ PFN_DOWN(ai->unit_size), base, ai->static_size, ai->reserved_size,
ai->dyn_size, ai->unit_size);
rc = pcpu_setup_first_chunk(ai, base);
--
1.8.1.2
next reply other threads:[~2014-10-25 19:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-25 15:05 Zhihui Zhang [this message]
2014-10-27 14:08 ` Tejun Heo
2014-10-27 23:32 ` Zhihui Zhang
2014-10-28 3:56 ` Tejun Heo
[not found] ` <CADFvMY+VUNaLhsJaPjH_DC91uJ8Hdgnaj9D44QEm0qV3Rr2-kA@mail.gmail.com>
[not found] ` <20141029041811.GA12382@htj.dyndns.org>
2014-10-30 0:07 ` Zhihui Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414249558-6677-1-git-send-email-zzhsuny@gmail.com \
--to=zzhsuny@gmail.com \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®