From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Peter Huewe <peterhuewe@gmx.de>,
Ashley Lai <ashley@ashleylai.com>,
Marcel Selhorst <tpmdd@selhorst.net>
Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
josh.triplett@intel.com, christophe.ricard@gmail.com,
jason.gunthorpe@obsidianresearch.com,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Subject: [PATCH v3 0/3] prepare for TPM 2.0
Date: Sun, 26 Oct 2014 11:13:54 +0200 [thread overview]
Message-ID: <1414314837-19722-1-git-send-email-jarkko.sakkinen@linux.intel.com> (raw)
This patch set fixes two race conditions in the TPM subsystem:
* Two-phase initialization for struct tpm_chip so that device can
initialize fully initialize before exposing itself to the user
space. Also, in future TPM2 devices must be flagged before they
can be registered.
* Machines where there are two TPM devices exposed by ACPI have
a racy lookup for the PPI interface. This patch set fixes this
issues
In addition, transmit_cmd() is renamed as tpm_transmit_cmd() and
made opaque so that separate command structure can be introduced
for TPM2.
Comments about v1:
* I think this could be pulled to 3.18 because this clearly fixes
bugs in the current implementation.
Changes since v1:
* Removed dev_dbgs from tpm-chip.c
* Use driver_lock for dev_mask (the problem was existing also in
tpm-interface.c when the code was moved).
* Check for bios_dir nullity when removed (the problem was existing
also in tpm-interface.c when the code was moved).
* Cleaned up the control flow in tpm_i2c_stm_st33.c and tpm_atmel.c.
* Cleaned up the control flow in tpm_ppi.c.
Comments about v2:
* Thanks to Jason Gunthorpe for reviewing v1.
* I'm at T2 infosec conference right now so I wasn't able to test the
force paths in tpm_atmel.c and tpm_tis.c.
Changes since v2:
* Regression in tpm-dev.c, must use tpm_transmit() instead of
tpm_transmit_cmd().
Jarkko Sakkinen (3):
tpm: merge duplicate transmit_cmd() functions
tpm: two-phase chip management functions
tpm: fix multiple race conditions in tpm_ppi.c
drivers/char/tpm/Makefile | 2 +-
drivers/char/tpm/tpm-chip.c | 196 +++++++++++++++++++++++++++++++++++
drivers/char/tpm/tpm-interface.c | 197 +++++-------------------------------
drivers/char/tpm/tpm-sysfs.c | 23 +----
drivers/char/tpm/tpm.h | 30 ++++--
drivers/char/tpm/tpm_atmel.c | 12 ++-
drivers/char/tpm/tpm_i2c_atmel.c | 33 ++----
drivers/char/tpm/tpm_i2c_infineon.c | 37 ++-----
drivers/char/tpm/tpm_i2c_nuvoton.c | 44 +++-----
drivers/char/tpm/tpm_i2c_stm_st33.c | 38 +++----
drivers/char/tpm/tpm_ibmvtpm.c | 17 ++--
drivers/char/tpm/tpm_infineon.c | 29 +++---
drivers/char/tpm/tpm_nsc.c | 14 ++-
drivers/char/tpm/tpm_ppi.c | 136 +++++++++++++++----------
drivers/char/tpm/tpm_tis.c | 94 ++++++++---------
drivers/char/tpm/xen-tpmfront.c | 14 +--
16 files changed, 467 insertions(+), 449 deletions(-)
create mode 100644 drivers/char/tpm/tpm-chip.c
--
2.1.0
next reply other threads:[~2014-10-26 9:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-26 9:13 Jarkko Sakkinen [this message]
2014-10-26 9:13 ` [PATCH v3 1/3] tpm: merge duplicate transmit_cmd() functions Jarkko Sakkinen
2014-10-26 9:13 ` [PATCH v3 2/3] tpm: two-phase chip management functions Jarkko Sakkinen
2014-10-26 9:13 ` [PATCH v3 3/3] tpm: fix multiple race conditions in tpm_ppi.c Jarkko Sakkinen
2014-10-27 9:55 ` [PATCH v3 0/3] prepare for TPM 2.0 Jarkko Sakkinen
2014-10-27 16:30 ` [tpmdd-devel] " Scot Doyle
2014-10-28 6:01 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414314837-19722-1-git-send-email-jarkko.sakkinen@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=ashley@ashleylai.com \
--cc=christophe.ricard@gmail.com \
--cc=jason.gunthorpe@obsidianresearch.com \
--cc=josh.triplett@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®