From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A92C27442 for ; Wed, 22 Oct 2025 17:17:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761153479; cv=none; b=kzeCGkPpNQuTtHVx4KHIVrl17lyrub4iw3I1ygm27KVJlh+Qv3pihNsh6zZ5QUBfTLWXBQUjGtQuW6qjEXI1HuEh4SHLvmmyyCaCh3RmpOyajwftw7hsImPia9nopfSoiv/xGWurJ4KuqbZ9mJGmAfGf/7p4Uvt6FJ/kyvBP8w8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761153479; c=relaxed/simple; bh=CExEECZTFOuFYGzdnRRTlZ94V5lWnXLzE5kfc7eohvI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i29fxMBPTtJf4qLYSw/aUAlaB2NhYoi4RD5iVY+G7RnBe0MA/bZxdfnhm4gBteyOp3oB71kR1ozYO3+ts11Fh+FmgwLq9M+HTN/4sHtfkxQdxrT8PDtoLRMzur2V/DwM2BaX+82zoyJxmof3ZJQBFYwN71TgBLRm2/Bt7DCV+ug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pqkFYBE6; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pqkFYBE6" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59MA6LoK024689 for ; Wed, 22 Oct 2025 17:17:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LyU88Pot6EZ2LgQ5OCVhej1+8SBV2PixZ/z1OwnNxwk=; b=pqkFYBE672cIdHE3 mg+w3U9r20hFTGdfjhhoJ0xXMLlcewwAMkJoo55Yyzbtc8H2tsdSdfLyHOA+/sOK IcLtpaR+peI2tYYYWY+nFFb0COsSgnC1YkwtJHDXSHjAPM2OMLGO6GG44OfGCIix dH1AF8ldaopxEKD22ITuRGkId42JCcl6aAgKcKsl82eDqcZmNGVtUbvPZ4Ho2DNJ ikxVGa1ruS9z8PpAIqNGnH6deXCwyQWSrfbGKRyh1mCgg5ZOWDOJXKLWRJ1t8y7G OVIesfsvFu9ZB0V6J+q63B5Omn4/2ZNEfZZHg9xksLiANOYKy+5wuzSYELSE91RS VIldAA== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49wsws7v0v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 22 Oct 2025 17:17:57 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4e8b90e9336so1340171cf.1 for ; Wed, 22 Oct 2025 10:17:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761153476; x=1761758276; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LyU88Pot6EZ2LgQ5OCVhej1+8SBV2PixZ/z1OwnNxwk=; b=nh54AhcezWdhqYJrMFLPyH+GBz2yjt8ISlpSPhqYJzKfi2iYEr1jhajdq6VudmTkMP h1ZeeJSvHfwPd2wXpDlUPL3e4gRdGjMDph002FX0SzaAXSe6h2RJg+SvbFCynwyP5PJf 988LXbFPaXrOSObkPhl1QTpqOmBA/SsoZOOtXZM9BXEGn/dTlESndHhZr+IQxodXEESL G3TI6+lsOj2woccm+p8VIM0k6AvPYCCFlQDaY7c67re6DUQngVowXPO1YvtrSpPbRYFI gdQr7F3+uQ5aihz6ddap1vWbyzqf7DkRQg+LkIogDtvEEodh9zgHfmiGDhVvgLJY6xQ+ RGgQ== X-Forwarded-Encrypted: i=1; AJvYcCUt54Fjwa9lpdCevmNN6s6syRwhYxRSMUGKFwrK60zjqTZbFM2JVBxDAAYHQ7hLcjuLsBPaOsMTmUL3sUU=@vger.kernel.org X-Gm-Message-State: AOJu0YxZZzc0qW3xFkfd1n7wXUx20nw5CdwCmZ3aK8b8N352BL89WhFg nMV6/mpcKge4sQgxSrbgesuRC3BnIRUjSTl1gONd5cyTVoI+lVWlZ0wOhU+FpiJDnmMeoxfWMMj QysbTVjO1Hn7PI+hoNvPeCuzAQDQCOSskKG1PmSEFzBgLc6xYZz+X5vKRxchgd6vjbBU= X-Gm-Gg: ASbGnculnXoUZVCn1KVFuW3GE6VaoJTQrYggwKfLxt/hY0JloR3Upl7qG+BPItLHjTx Loq4l84zEACHqDcmpOAb18qIDLV+QVnVawMAB8y+m6gx7sj2Ojnaz1eF/qPrHlts5pF27WvlZhQ Dws/upSWnT+lfFlWe3+huhlPBabwJNtra3rBR43yfKGoLujqIvctIdACg2ZIhVRXOfK8Sm4PcME HOkdZHPxRb2Y8IX1IgY51QnoM5J2IlnFnRlO95NSBJqbVfxqECBnR01chzPjzrwSATr/0jSiVQo 3goHlhFkK7eNp6W2fCmJq86kA+aeKSLJ9VbvvmMGxez5KEsuuWk5G68SY7C7qKQ5f3uY7dmeh0b SsOzuFJT+PNYRWSWe093kn4N6V7woIkxwsy5lrCkHH5zvRY8eXujQvilc X-Received: by 2002:ac8:7d89:0:b0:4b7:94f1:7722 with SMTP id d75a77b69052e-4ea1155ca2dmr64258911cf.0.1761153476116; Wed, 22 Oct 2025 10:17:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF0FvIF8PqRON9r2jQFOp30M/SkUX6E0MHABKJZmBOkOv2WvHcZhGWybIVBgEjPUf0XJZccsQ== X-Received: by 2002:ac8:7d89:0:b0:4b7:94f1:7722 with SMTP id d75a77b69052e-4ea1155ca2dmr64258551cf.0.1761153475641; Wed, 22 Oct 2025 10:17:55 -0700 (PDT) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-63c4945ef35sm12967508a12.28.2025.10.22.10.17.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Oct 2025 10:17:54 -0700 (PDT) Message-ID: <141450a6-4578-4823-b516-d180eaf3ccc7@oss.qualcomm.com> Date: Wed, 22 Oct 2025 19:17:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: qcom: sdm630/660: Add CDSP-related nodes To: Nickolay Goppen , Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org References: <20251019-qcom-sdm660-cdsp-adsp-dts-v1-0-9ab5f2865a6e@mainlining.org> <20251019-qcom-sdm660-cdsp-adsp-dts-v1-1-9ab5f2865a6e@mainlining.org> <5hbc24lihvau7s2opzcxxgxkzugmbqmdtqwy23m45j4po23lnh@jyjlbgfjaddw> <0ca0bdfe-b228-49be-9ef7-71482d372e0f@mainlining.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <0ca0bdfe-b228-49be-9ef7-71482d372e0f@mainlining.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDIwMDE0OCBTYWx0ZWRfX8EbBmda/tsSx Wqka3aXBZP+9SMdYUGhSAKqfJ0B1BoXf8EwzG8vAe4rWJslM+z/Yg/bB/gd8T+pWkRDQ8NxlxKn 8k/qO6Qif5xqQPyP1jDKhrYYU2lnzN4ETY7RWRv79TyY5oTo+vLlp92NK2+oAL1zNuev7jpki+P YG9s8dLsUMyFRAub+CJ7hInIO4XIaJPkZcYrbaYvfipzK6iTN/Hr3bHAcVZ15MuN/y2jl7aKk3q t6mXAHirCUgUyei9FNdp2tDEQB7sD7CizKXFlUrdjwYK6NX4VlHXAbuZwLpDSfYfi6ccbv4sSG1 +OXi2waCRIZR6QemubJepLe/mSMQ+xK/uT+ZDlnuqHCX2pQRR4PVePv3jgRCbYWHAUJ9vXM3v1W 361VhENN4GyQnhjpTeIXUGRYyhhoJw== X-Proofpoint-GUID: YjjyF-92Hj2L4ZVMG2Wz6tM4fzdc8GbD X-Proofpoint-ORIG-GUID: YjjyF-92Hj2L4ZVMG2Wz6tM4fzdc8GbD X-Authority-Analysis: v=2.4 cv=a+E9NESF c=1 sm=1 tr=0 ts=68f911c5 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=OuZLqq7tAAAA:8 a=q0T5L8gon9ZBDEW-TvIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=AKGiAy9iJ-JzxKVHQNES:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-22_07,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 clxscore=1015 priorityscore=1501 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510200148 On 10/20/25 5:42 PM, Nickolay Goppen wrote: > > 20.10.2025 18:27, Nickolay Goppen пишет: >> >> 20.10.2025 16:14, Dmitry Baryshkov пишет: >>> On Sun, Oct 19, 2025 at 07:27:06PM +0300, Nickolay Goppen wrote: >>>> In order to enable CDSP support for SDM660 SoC: >>>>   * add shared memory p2p nodes for CDSP >>>>   * add CDSP-specific smmu node >>>>   * add CDSP peripheral image loader node >>>> >>>> Memory region for CDSP in SDM660 occupies the same spot as >>>> TZ buffer mem defined in sdm630.dtsi (which does not have CDSP). >>>> In sdm660.dtsi replace buffer_mem inherited from SDM630 with >>>> cdsp_region, which is also larger in size. >>>> >>>> SDM636 also doesn't have CDSP, so remove inherited from sdm660.dtsi >>>> related nodes and add buffer_mem back. >>>> >>>> Signed-off-by: Nickolay Goppen >>>> --- >>>>   arch/arm64/boot/dts/qcom/sdm630.dtsi |   2 +- >>>>   arch/arm64/boot/dts/qcom/sdm636.dtsi |  14 ++++ >>>>   arch/arm64/boot/dts/qcom/sdm660.dtsi | 152 +++++++++++++++++++++++++++++++++++ >>>>   3 files changed, 167 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi >>>> index 8b1a45a4e56e..a6a1933229b9 100644 >>>> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi >>>> @@ -563,7 +563,7 @@ modem_smp2p_in: slave-kernel { >>>>           }; >>>>       }; >>>>   -    soc@0 { >>>> +    soc: soc@0 { >>>>           #address-cells = <1>; >>>>           #size-cells = <1>; >>>>           ranges = <0 0 0 0xffffffff>; >>>> diff --git a/arch/arm64/boot/dts/qcom/sdm636.dtsi b/arch/arm64/boot/dts/qcom/sdm636.dtsi >>>> index ae15d81fa3f9..41e4e97f7747 100644 >>>> --- a/arch/arm64/boot/dts/qcom/sdm636.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/sdm636.dtsi >>>> @@ -16,6 +16,20 @@ >>>>    * be addressed when the aforementioned >>>>    * peripherals will be enabled upstream. >>>>    */ >>>> +/delete-node/ &cdsp_pil; >>>> +/delete-node/ &cdsp_smmu; >>>> +/delete-node/ &cdsp_region; >>>> + >>>> +/ { >>>> +    /delete-node/ smp2p-cdsp; >>>> + >>>> +    reserved-memory { >>>> +        buffer_mem: tzbuffer@94a00000 { >>>> +            reg = <0x00 0x94a00000 0x00 0x100000>; >>>> +            no-map; >>>> +        }; >>>> +    }; >>>> +}; >>> This probably means that we need to invert things and make SDM636 >>> inherit SDM630 and SDM660 inherit SDM636. Would you mind doing that as a >>> part of this patchset? >> I'd mind > Konrad decided to do the split this way for some reason initially This isn't a very good argument, but I think keeping it as-is is a good idea in this case, as opening sdm660.dtsi I see a need for some more cleanup work on this platform.. which I don't think anyone is willing to do short term, this is less invasive Konrad