mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Martin Kepplinger <martink@posteo.de>
To: gregkh@linuxfoundation.org
Cc: arnd@arndb.de, akpm@linux-foundation.org, rusty@rustcorp.com.au,
	linux-kernel@vger.kernel.org,
	Martin Kepplinger <martink@posteo.de>
Subject: [PATCH 0/3] char: misc: assign file->private_data to miscdevice on open
Date: Wed, 29 Oct 2014 20:22:55 +0100	[thread overview]
Message-ID: <1414610578-22779-1-git-send-email-martink@posteo.de> (raw)

This slightly changes the behaviour of miscdevice drivers at an open()
syscall. Not only if the driver happens to implement an open() fop itself,
but now just always file->private_data points to struct miscdevice, when
a user opens the device file.

This call for review once more: if anybody has an hour to kill:

Look for the only dangerous situation where a miscdevice driver _depends_ on
file->private_data being NULL when _not_ implementing an open() routine
itself. I didn't find anything.

The one section I was unsure about should be ok, see
http://marc.info/?l=linux-kernel&m=141376535132316&w=2

Bonus: one could look for drivers that _do_ implement open()
and do the (in any case) redundant work themselves.

Martin Kepplinger (3):
  misc: always assign miscdevice to file->private_data in open()
  fbdev: pxa3xx-gcu: remove redundant implementation of open()
  char: misc: document behaviour of open()

 drivers/char/misc.c              |    6 ++++--
 drivers/video/fbdev/pxa3xx-gcu.c |   10 ----------
 2 files changed, 4 insertions(+), 12 deletions(-)

-- 
1.7.10.4


             reply	other threads:[~2014-10-29 19:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-29 19:22 Martin Kepplinger [this message]
2014-10-29 19:22 ` [PATCH 1/3] misc: always assign miscdevice to file->private_data in open() Martin Kepplinger
2014-10-29 19:22 ` [PATCH 2/3] fbdev: pxa3xx-gcu: remove redundant implementation of open() Martin Kepplinger
2014-10-29 19:22 ` [PATCH 3/3] char: misc: document behaviour " Martin Kepplinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414610578-22779-1-git-send-email-martink@posteo.de \
    --to=martink@posteo.de \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®