mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Behan Webster <behanw@converseincode.com>
To: andriy.shevchenko@linux.intel.com, aysemelikeyurtoglu@gmail.com,
	matthias.schoepe@studium.uni-erlangen.de, mdcasey@chabloom.com,
	peter.senna@gmail.com, rashika.kheria@gmail.com,
	standby24x7@gmail.com
Cc: behanw@converseincode.com, akpm@linux-foundation.org,
	andreas.frembs@studium.uni-erlangen.de,
	devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, mahati.chamarthy@gmail.com,
	peter.p.waskiewicz.jr@intel.com, quozl@laptop.org,
	valentina.manea.m@gmail.com, Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH 1/4] staging, rtl8192e, LLVMLinux: Change extern inline to static inline
Date: Wed, 29 Oct 2014 15:42:20 -0700	[thread overview]
Message-ID: <1414622543-22969-2-git-send-email-behanw@converseincode.com> (raw)
In-Reply-To: <1414622543-22969-1-git-send-email-behanw@converseincode.com>

With compilers which follow the C99 standard (like modern versions of gcc and
clang), "extern inline" does the opposite thing from older versions of gcc
(emits code for an externally linkable version of the inline function).

"static inline" does the intended behavior in all cases instead.

Signed-off-by: Behan Webster <behanw@converseincode.com>
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Cc: Arnd Bergmann <arnd@arndb.de>
---
 drivers/staging/rtl8192e/rtllib.h         | 4 ++--
 drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 2d82f89..33995ac 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -2944,12 +2944,12 @@ void rtllib_softmac_scan_syncro(struct rtllib_device *ieee, u8 is_mesh);
 
 extern const long rtllib_wlan_frequencies[];
 
-extern inline void rtllib_increment_scans(struct rtllib_device *ieee)
+static inline void rtllib_increment_scans(struct rtllib_device *ieee)
 {
 	ieee->scans++;
 }
 
-extern inline int rtllib_get_scans(struct rtllib_device *ieee)
+static inline int rtllib_get_scans(struct rtllib_device *ieee)
 {
 	return ieee->scans;
 }
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index abb6729..067a45a 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -343,7 +343,7 @@ inline void softmac_ps_mgmt_xmit(struct sk_buff *skb,
 	}
 }
 
-inline struct sk_buff *rtllib_probe_req(struct rtllib_device *ieee)
+static inline struct sk_buff *rtllib_probe_req(struct rtllib_device *ieee)
 {
 	unsigned int len, rate_len;
 	u8 *tag;
-- 
1.9.1


  reply	other threads:[~2014-10-29 22:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-29 22:42 [PATCH 0/4] staging, rtl8192e, LLVMLinux: Patches to enable the kernel to be compiled with clang/LLVM Behan Webster
2014-10-29 22:42 ` Behan Webster [this message]
2014-10-29 22:42 ` [PATCH 2/4] staging, rtl8192e, LLVMLinux: Remove unused inline prototype Behan Webster
2014-10-29 22:42 ` [PATCH 3/4] staging, rtl8192e, LLVMLinux: Remove unused prototype Behan Webster
2014-10-29 22:42 ` [PATCH 4/4] staging, rtl8192e, LLVMLinux: Make static local in inline function const Behan Webster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414622543-22969-2-git-send-email-behanw@converseincode.com \
    --to=behanw@converseincode.com \
    --cc=akpm@linux-foundation.org \
    --cc=andreas.frembs@studium.uni-erlangen.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=aysemelikeyurtoglu@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mahati.chamarthy@gmail.com \
    --cc=matthias.schoepe@studium.uni-erlangen.de \
    --cc=mdcasey@chabloom.com \
    --cc=peter.p.waskiewicz.jr@intel.com \
    --cc=peter.senna@gmail.com \
    --cc=quozl@laptop.org \
    --cc=rashika.kheria@gmail.com \
    --cc=standby24x7@gmail.com \
    --cc=valentina.manea.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®