From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965572AbdGTPsb (ORCPT ); Thu, 20 Jul 2017 11:48:31 -0400 Received: from resqmta-po-06v.sys.comcast.net ([96.114.154.165]:44606 "EHLO resqmta-po-06v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935871AbdGTPsa (ORCPT ); Thu, 20 Jul 2017 11:48:30 -0400 Reply-To: shuah@kernel.org Subject: Re: [PATCH] [media] dvb_frontend: ensure that front end status is initialized To: Colin King , Max Kellermann , Sakari Ailus , Markus Elfring , Hans Verkuil , Masahiro Yamada , linux-media@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , Shuah Khan References: <20170720152916.24266-1-colin.king@canonical.com> From: Shuah Khan Message-ID: <141477a2-1435-b74a-3ee9-1eeb6765dc12@kernel.org> Date: Thu, 20 Jul 2017 09:48:27 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170720152916.24266-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfP6dpEFBciOsSH1dsKdyqkSVhk61Qga0Izn0g8gCVMTyhkylx54/puu6WZGWspod+A9zmZS7XKwJnfLajEFQAudKW1pkBc4NgSW2kXqm9L4FrXDdO7m0 pErsQvw+46TXEj2m6ZHkmBZGyXFopwDurYkBCBzmVAr6zx582xw/MxD44key+e1aSxt/zWYt6rK260aZjZAtJGbdGf0mwDYQAKzv9Hc7xe/eoyWCtu+r3ju4 gTVJCBWo/0QyMLRuKDIdh6JMQKf0lNWPPOTTWKcIXOvlPDoTbG/GSm0KTuiZHU1WqQSilcfPkWYsNMQtcsORf9rfFdwcmffzyOBpGbCeQTASmmeZzF4CiQJV rrfkmigq7yxdgVAdx2dJLeAlR05LRUNzIdIabGO8Irw8a/DMmeji62tk+K34U2JX2iXRA4DBQE964LUQZi7BGr99FpNStD743cMZwaF4rIV4PYLL/HCfTPfP MOntDKHCbmpTtZeagRjGIpPmEdIPkM3kjlnjhMyZw9sag8GdC/U6vcgpVe0kS9zobwDpMYA3fuu7dQURtsajm5kt54KSf3ZF2EI3mg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Colin, On 07/20/2017 09:29 AM, Colin King wrote: > From: Colin Ian King > > The fe_status variable s is not initialized meaning it can have any > random garbage status. This could be problematic if fe->ops.tune is > false as s is not updated by the call to fe->ops.tune() and a > subsequent check on the change status will using a garbage value. > Fix this by initializing s to zero. > > Detected by CoverityScan, CID#112887 ("Uninitialized scalar variable") > > Signed-off-by: Colin Ian King > --- > drivers/media/dvb-core/dvb_frontend.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core/dvb_frontend.c > index e3fff8f64d37..e18ea1508a59 100644 > --- a/drivers/media/dvb-core/dvb_frontend.c > +++ b/drivers/media/dvb-core/dvb_frontend.c > @@ -631,7 +631,7 @@ static int dvb_frontend_thread(void *data) > struct dvb_frontend *fe = data; > struct dtv_frontend_properties *c = &fe->dtv_property_cache; > struct dvb_frontend_private *fepriv = fe->frontend_priv; > - enum fe_status s; > + enum fe_status s = 0; 0 isn't a valid value for enum fe_status. I think the right fix would be to add FE_NONE to enum fe_status and then initialize s to that. thanks, -- Shuah > enum dvbfe_algo algo; > bool re_tune = false; > bool semheld = false; >