From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754102AbaKCSMc (ORCPT ); Mon, 3 Nov 2014 13:12:32 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:38953 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752877AbaKCSMa (ORCPT ); Mon, 3 Nov 2014 13:12:30 -0500 From: Markus Pargmann To: Mark Brown Cc: Liam Girdwood , =?UTF-8?q?Krzysztof=20Koz=C5=82owski?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Markus Pargmann Subject: [PATCH v3 3/4] regulator: gpio: Use gpio_is_valid Date: Mon, 3 Nov 2014 19:12:06 +0100 Message-Id: <1415038327-32616-4-git-send-email-mpa@pengutronix.de> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1415038327-32616-1-git-send-email-mpa@pengutronix.de> References: <1415038327-32616-1-git-send-email-mpa@pengutronix.de> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: mpa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use gpio_is_valid instead of an explicit comparison with 0. Signed-off-by: Markus Pargmann --- drivers/regulator/gpio-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c index 5da0125fac6a..86546c1c32c4 100644 --- a/drivers/regulator/gpio-regulator.c +++ b/drivers/regulator/gpio-regulator.c @@ -322,7 +322,7 @@ static int gpio_regulator_probe(struct platform_device *pdev) cfg.driver_data = drvdata; cfg.of_node = np; - if (config->enable_gpio >= 0) { + if (gpio_is_valid(config->enable_gpio)) { cfg.ena_gpio = config->enable_gpio; cfg.ena_gpio_initialized = true; } -- 2.1.1