From: varkabhadram@gmail.com
To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org
Cc: balbi@ti.com, stern@rowland.harvard.edu,
sergei.shtylyov@cogentembedded.com, linux-kernel@vger.kernel.org,
Varka Bhadram <varkabhadram@gmail.com>,
Varka Bhadram <varkab@cdac.in>
Subject: [PATCH usb v4 20/27] host: xhci-plat: remove duplicate check on resource
Date: Tue, 4 Nov 2014 07:51:27 +0530 [thread overview]
Message-ID: <1415067694-9473-21-git-send-email-varkabhadram@gmail.com> (raw)
In-Reply-To: <1415067694-9473-1-git-send-email-varkabhadram@gmail.com>
From: Varka Bhadram <varkabhadram@gmail.com>
Sanity check on resource happening with devm_ioremap_resource().
Signed-off-by: Varka Bhadram <varkab@cdac.in>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Acked-by: Felipe Balbi <balbi@ti.com>
Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
---
drivers/usb/host/xhci-plat.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index 3d78b0c..e68b4ec 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -83,9 +83,6 @@ static int xhci_plat_probe(struct platform_device *pdev)
if (irq < 0)
return -ENODEV;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return -ENODEV;
if (of_device_is_compatible(pdev->dev.of_node,
"marvell,armada-375-xhci") ||
@@ -109,15 +106,16 @@ static int xhci_plat_probe(struct platform_device *pdev)
if (!hcd)
return -ENOMEM;
- hcd->rsrc_start = res->start;
- hcd->rsrc_len = resource_size(res);
-
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
hcd->regs = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(hcd->regs)) {
ret = PTR_ERR(hcd->regs);
goto put_hcd;
}
+ hcd->rsrc_start = res->start;
+ hcd->rsrc_len = resource_size(res);
+
/*
* Not all platforms have a clk so it is not an error if the
* clock does not exists.
--
1.7.9.5
next prev parent reply other threads:[~2014-11-04 2:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 2:21 [PATCH usb v4 00/27] cleanup on resource check varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 01/27] host: ehci-atmel: remove duplicate check on resource varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 02/27] host: ohci-da8xx: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 03/27] host: ehci-tegra: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 04/27] host: ehci-w90x900: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 05/27] host: ohci-at91: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 06/27] host: ohci-exynos: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 07/27] host: ohci-jz4740: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 08/27] host: ohci-octeon: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 09/27] host: ohci-platform: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 10/27] host: ohci-pxa27x: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 11/27] host: ehci-sh: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 12/27] host: ohci-spear: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 13/27] host: ehci-msm: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 14/27] host: ehci-mv: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 15/27] host: ehci-mxc: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 16/27] host: ehci-octeon: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 17/27] host: ehci-orion: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 18/27] host: ehci-platform: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 19/27] host: ehci-spear: " varkabhadram
2014-11-04 2:21 ` varkabhadram [this message]
2014-11-04 2:21 ` [PATCH usb v4 21/27] musb: musb_core: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 22/27] musb: musb_dsps: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 23/27] phy: phy-rcar-usb: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 24/27] dwc3: dwc3-keystone: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 25/27] host: ehci-fsl: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 26/27] host: ehci-exynos: " varkabhadram
2014-11-04 2:21 ` [PATCH usb v4 27/27] renesas_usbhs: common: " varkabhadram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415067694-9473-21-git-send-email-varkabhadram@gmail.com \
--to=varkabhadram@gmail.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stern@rowland.harvard.edu \
--cc=varkab@cdac.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome