mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Stringer <joestringer@nicira.com>
To: netdev@vger.kernel.org
Cc: sathya.perla@emulex.com, jeffrey.t.kirsher@intel.com,
	linux.nics@intel.com, amirv@mellanox.com,
	shahed.shaikh@qlogic.com, Dept-GELinuxNICDev@qlogic.com,
	therbert@google.com, linux-kernel@vger.kernel.org
Subject: [PATCH net 3/5] fm10k: Implement ndo_gso_check()
Date: Tue,  4 Nov 2014 13:56:40 -0800	[thread overview]
Message-ID: <1415138202-1197-4-git-send-email-joestringer@nicira.com> (raw)
In-Reply-To: <1415138202-1197-1-git-send-email-joestringer@nicira.com>

ndo_gso_check() was recently introduced to allow NICs to report the
offloading support that they have on a per-skb basis. Add an
implementation for this driver which checks for something that looks
like VXLAN.

Implementation shamelessly stolen from Tom Herbert:
http://thread.gmane.org/gmane.linux.network/332428/focus=333111

Signed-off-by: Joe Stringer <joestringer@nicira.com>
---
Should this driver report support for GSO on packets with tunnel headers
up to 64B like the i40e driver does?
---
 drivers/net/ethernet/intel/fm10k/fm10k_netdev.c |   12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c
index 8811364..b9ef622 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c
@@ -1350,6 +1350,17 @@ static void fm10k_dfwd_del_station(struct net_device *dev, void *priv)
 	}
 }
 
+static bool fm10k_gso_check(struct sk_buff *skb, struct net_device *dev)
+{
+	if ((skb_shinfo(skb)->gso_type & SKB_GSO_UDP_TUNNEL) &&
+	    (skb->inner_protocol_type != ENCAP_TYPE_ETHER ||
+	     skb->inner_protocol != htons(ETH_P_TEB) ||
+	     skb_inner_mac_header(skb) - skb_transport_header(skb) != 16))
+		return false;
+
+	return true;
+}
+
 static const struct net_device_ops fm10k_netdev_ops = {
 	.ndo_open		= fm10k_open,
 	.ndo_stop		= fm10k_close,
@@ -1372,6 +1383,7 @@ static const struct net_device_ops fm10k_netdev_ops = {
 	.ndo_do_ioctl		= fm10k_ioctl,
 	.ndo_dfwd_add_station	= fm10k_dfwd_add_station,
 	.ndo_dfwd_del_station	= fm10k_dfwd_del_station,
+	.ndo_gso_check		= fm10k_gso_check,
 };
 
 #define DEFAULT_DEBUG_LEVEL_SHIFT 3
-- 
1.7.10.4


  parent reply	other threads:[~2014-11-04 22:04 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04 21:56 [PATCH net 0/5] Implement ndo_gso_check() for vxlan nics Joe Stringer
2014-11-04 21:56 ` [PATCH net 1/5] be2net: Implement ndo_gso_check() Joe Stringer
2014-11-04 21:56 ` [PATCH net 2/5] i40e: " Joe Stringer
2014-11-04 23:45   ` Jesse Gross
2014-11-05 12:37     ` Jeff Kirsher
2014-11-20 19:16     ` Joe Stringer
2014-11-20 20:14       ` Jesse Gross
2014-11-05 12:35   ` Jeff Kirsher
2014-11-04 21:56 ` Joe Stringer [this message]
2014-11-05 12:34   ` [linux-nics] [PATCH net 3/5] fm10k: " Jeff Kirsher
2014-11-05 12:44     ` Or Gerlitz
2014-11-05 12:47       ` Jeff Kirsher
     [not found]         ` <CANr6G5xBehKGVozOAM=m8CXY7Q8_kPu-s5zgwho4=npv=bQsrg@mail.gmail.com>
2014-11-05 19:36           ` Jeff Kirsher
     [not found]             ` <D0814A3F.5EA53%matthew.vick@intel.com>
2014-11-07  0:55               ` Joe Stringer
     [not found]                 ` <D0815B72.5EAF9%matthew.vick@intel.com>
2014-11-07  4:51                   ` Joe Stringer
2014-11-06  2:54   ` Alexander Duyck
2014-11-06 18:41     ` Joe Stringer
2014-11-06 21:15       ` Joe Stringer
2014-11-07  1:07         ` Vick, Matthew
2014-11-07  5:05           ` Joe Stringer
2014-11-07 19:49             ` Vick, Matthew
2014-11-07 22:35               ` Joe Stringer
2014-11-08  0:51                 ` Vick, Matthew
2014-11-04 21:56 ` [PATCH net 4/5] net/mlx4_en: " Joe Stringer
2014-11-05 12:41   ` Or Gerlitz
2014-11-04 21:56 ` [PATCH net 5/5] qlcnic: " Joe Stringer
2014-11-05  9:17   ` Shahed Shaikh
2014-11-05 12:38 ` [PATCH net 0/5] Implement ndo_gso_check() for vxlan nics Or Gerlitz
     [not found]   ` <CANr6G5xtNYenhd8KDWx+kRcnSZ0fahUdAL+6Wcz=5_dNvrQR6Q@mail.gmail.com>
2014-11-05 18:00     ` Tom Herbert
2014-11-05 21:32       ` Or Gerlitz
2014-11-05 21:38         ` David Miller
2014-11-06  1:06           ` Joe Stringer
2014-11-06  2:15             ` David Miller
2014-11-06  2:44               ` Tom Herbert
2014-11-06  8:23                 ` Or Gerlitz
     [not found]                 ` <CF9D1877D81D214CB0CA0669EFAE020C68CC79EF@CMEXMB1.ad.emulex.com>
2014-11-06 16:06                   ` Tom Herbert
2014-11-06 16:15                     ` Jesse Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415138202-1197-4-git-send-email-joestringer@nicira.com \
    --to=joestringer@nicira.com \
    --cc=Dept-GELinuxNICDev@qlogic.com \
    --cc=amirv@mellanox.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux.nics@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=sathya.perla@emulex.com \
    --cc=shahed.shaikh@qlogic.com \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®