From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: Mike Looijmans <mike.looijmans@topic.nl>,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Subject: Re: [PATCH v2] Add ltc3562 voltage regulator driver
Date: Wed, 05 Nov 2014 10:06:43 +0100 [thread overview]
Message-ID: <1415178403.15850.17.camel@AMDC1943> (raw)
In-Reply-To: <20141104194729.GV3815@sirena.org.uk>
On wto, 2014-11-04 at 19:47 +0000, Mark Brown wrote:
> On Tue, Nov 04, 2014 at 02:35:50PM +0100, Mike Looijmans wrote:
>
> > I still need help with one thing that isn't clear to me though. The DT is
> > parsed when calling regulator_register. But then how do I fetch my "private"
> > settings in there BEFORE the regulator gets enabled? The feedback resistors
> > and regulator mode must be set to the correct board before the output is
> > enabled, otherwise it may damage the chip and its periferals.
>
> Add a callback for this. Javier and/or Krzysztof were looking at this
> for some other stuff, though I think they were intending to add core
> functionality for their specific feature.
I needed a callback and added such. The callback was called on each DT
node parsed. However I dropped that idea because it turned our to be
unsuitable to my case.
I needed to feed regulator_config.ena_gpio with data parsed from such
callback. But the callback called from inside the regulator_register()
has the regulator_config const.
Best regards,
Krzysztof
next prev parent reply other threads:[~2014-11-05 9:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 8:15 Mike Looijmans
2014-10-29 8:16 ` [PATCH] " Mike Looijmans
2014-10-29 12:30 ` Mark Brown
2014-10-30 6:47 ` Mike Looijmans
2014-10-30 10:15 ` Mark Brown
2014-10-30 10:29 ` Mike Looijmans
2014-10-30 10:53 ` Mike Looijmans
2014-10-30 10:58 ` Mark Brown
2014-10-30 11:31 ` Mike Looijmans
2014-10-30 12:04 ` Mark Brown
2014-10-30 11:26 ` [PATCH v2] " Mike Looijmans
2014-10-30 16:51 ` Mark Brown
2014-10-31 14:07 ` Mike Looijmans
2014-10-31 18:17 ` Mark Brown
2014-11-03 8:10 ` Mike Looijmans
2014-11-03 12:09 ` Mark Brown
2014-11-03 14:48 ` Mike Looijmans
2014-11-03 15:10 ` Mark Brown
2014-11-03 17:38 ` Mike Looijmans
2014-11-04 8:55 ` Mike Looijmans
2014-11-04 11:34 ` Mark Brown
2014-11-04 12:47 ` Mike Looijmans
2014-11-04 13:35 ` Mike Looijmans
2014-11-04 19:47 ` Mark Brown
2014-11-05 9:06 ` Krzysztof Kozlowski [this message]
2014-11-05 11:45 ` Mike Looijmans
2014-11-04 6:50 ` [PATCH v3] " Mike Looijmans
2014-11-04 20:26 ` Mark Brown
2014-11-05 11:41 ` Mike Looijmans
2014-11-05 13:34 ` Mark Brown
2014-10-29 10:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415178403.15850.17.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=broonie@kernel.org \
--cc=javier.martinez@collabora.co.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome