From: Joe Perches <joe@perches.com>
To: Sanjeev Sharma <sanjeev_sharma@mentor.com>
Cc: Larry.Finger@lwfinger.net, Jes.Sorensen@redhat.com,
gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging:rtl8723au: core: Fix error reported by checkpatch.
Date: Wed, 05 Nov 2014 09:15:47 -0800 [thread overview]
Message-ID: <1415207747.6634.15.camel@perches.com> (raw)
In-Reply-To: <1415187303-28541-1-git-send-email-sanjeev_sharma@mentor.com>
On Wed, 2014-11-05 at 17:05 +0530, Sanjeev Sharma wrote:
> This is a patch to the rtw_cmd.c file that fixes
> Error reported by checkpatch.
Please run your patches through checkpatch before
sending them.
WARNING: suspect code indent for conditional statements (24, 24)
#178: FILE: drivers/staging/rtl8723au/core/rtw_cmd.c:1025:
+ if (check_fwstate(pmlmepriv, _FW_LINKED))
LPS_Leave23a(padapter);
Also, there are a couple of different things
you changing here.
This should be 2 separate patches.
One to use the temporary for:
+ struct rt_link_detect *ldi = &pmlmepriv->LinkDetectInfo;
(and that bit has a defect here:
+ } else {
LPS_Leave23a(padapter);
+ }
where the indentation for the last close brace is wrong)
and another for the whitespace only changes
next prev parent reply other threads:[~2014-11-05 17:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 7:59 [PATCH] " Sanjeev Sharma
2014-10-27 8:43 ` Jes Sorensen
2014-10-27 14:52 ` Joe Perches
2014-10-29 6:35 ` Sharma, Sanjeev
2014-10-30 14:50 ` Jes Sorensen
2014-11-05 11:35 ` [PATCH v2] " Sanjeev Sharma
2014-11-05 16:27 ` Greg KH
2014-11-06 6:37 ` Sharma, Sanjeev
2014-11-05 17:15 ` Joe Perches [this message]
2014-11-06 5:41 ` Sharma, Sanjeev
2014-11-05 11:38 ` [PATCH] " Sharma, Sanjeev
2014-11-06 6:16 ` Sanjeev Sharma
2014-11-06 15:41 ` Greg KH
2014-11-07 11:56 ` Sharma, Sanjeev
2014-11-06 6:36 ` [PATCH] staging:rtl8723au: core: Fix Warning " Sanjeev Sharma
2014-11-06 15:43 ` Greg KH
2014-11-07 12:00 ` Sharma, Sanjeev
2014-11-07 15:46 ` Jes Sorensen
2014-11-11 7:54 ` [PATCH] staging:rtl8723au: core: Added missing space " Sanjeev Sharma
2014-11-11 9:58 ` [PATCH] staging:rtl8723au: core: Fix checkpatch warning Sanjeev Sharma
2014-10-30 7:47 ` [PATCH] staging:rtl8723au: core: Fix error reported by checkpatch Jes Sorensen
2014-10-29 6:32 ` Sharma, Sanjeev
2014-10-30 14:49 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415207747.6634.15.camel@perches.com \
--to=joe@perches.com \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sanjeev_sharma@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®