From: Peter Hurley <peter@hurleysoftware.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.cz>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Peter Hurley <peter@hurleysoftware.com>
Subject: [PATCH -next 0/5] set_ldisc notification fixes
Date: Wed, 5 Nov 2014 13:11:40 -0500 [thread overview]
Message-ID: <1415211105-16668-1-git-send-email-peter@hurleysoftware.com> (raw)
Hi Greg,
This patch series fixes several locking and functional problems
with the .set_ldisc() notification sent by the tty core:
1) termios is used without holding termios_rwsem
2) uart port flags are changed without holding port mutex
3) several of the drivers call their enable_ms() routines directly
without holding port lock
4) The set_ldisc notification will turn on modem status interrupts
if the CD line is being used for N_PPS time signal, but doesn't
turn modem status interrupts back off if N_PPS is being unset.
Note: this series depends on the 26-patch 'tty locking changes'
series and the 10-patch 'serial core fixes' series.
Regards,
Peter Hurley (5):
tty: Allow safe access to termios for set_ldisc() handlers
serial: core: Claim port mutex for set_ldisc()
serial: core: Pass termios to set_ldisc() notifications
serial: Take uart port lock for direct *_enable_ms()
serial: Test/disable MSIs if switching from N_PPS
drivers/tty/serial/8250/8250_core.c | 27 ++++++++++++++++++++++++---
drivers/tty/serial/amba-pl010.c | 24 +++++++++++++++++++++---
drivers/tty/serial/atmel_serial.c | 11 +++++++++--
drivers/tty/serial/bfin_uart.c | 5 +++--
drivers/tty/serial/clps711x.c | 5 +++--
drivers/tty/serial/serial_core.c | 7 +++++--
drivers/tty/tty_ldisc.c | 5 ++++-
include/linux/serial_core.h | 2 +-
8 files changed, 70 insertions(+), 16 deletions(-)
--
2.1.3
next reply other threads:[~2014-11-05 18:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 18:11 Peter Hurley [this message]
2014-11-05 18:11 ` [PATCH -next 1/5] tty: Allow safe access to termios for set_ldisc() handlers Peter Hurley
2014-11-05 18:11 ` [PATCH -next 2/5] serial: core: Claim port mutex for set_ldisc() Peter Hurley
2014-11-05 18:11 ` [PATCH -next 3/5] serial: core: Pass termios to set_ldisc() notifications Peter Hurley
2014-11-05 18:11 ` [PATCH -next 4/5] serial: Take uart port lock for direct *_enable_ms() Peter Hurley
2014-11-05 18:11 ` [PATCH -next 5/5] serial: Test/disable MSIs if switching from N_PPS Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415211105-16668-1-git-send-email-peter@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome