From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751340AbaKEWvx (ORCPT ); Wed, 5 Nov 2014 17:51:53 -0500 Received: from smtprelay0154.hostedemail.com ([216.40.44.154]:59951 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750867AbaKEWvw (ORCPT ); Wed, 5 Nov 2014 17:51:52 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1801:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3872:3874:4321:4605:5007:6119:6261:7901:9121:10004:10400:10848:10967:11026:11232:11233:11473:11658:11914:12296:12438:12517:12519:12679:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: gold52_84697b7d0832b X-Filterd-Recvd-Size: 2601 Message-ID: <1415227908.6634.30.camel@perches.com> Subject: Re: [PATCH 4/6] trace: Replace seq_printf by simpler equivalents From: Joe Perches To: Steven Rostedt Cc: Rasmus Villemoes , Julia Lawall , Ingo Molnar , linux-kernel@vger.kernel.org Date: Wed, 05 Nov 2014 14:51:48 -0800 In-Reply-To: <20141105173454.7aa47289@gandalf.local.home> References: <1410513954-28909-1-git-send-email-linux@rasmusvillemoes.dk> <1410513954-28909-5-git-send-email-linux@rasmusvillemoes.dk> <20141105173454.7aa47289@gandalf.local.home> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2014-11-05 at 17:34 -0500, Steven Rostedt wrote: > On Fri, 12 Sep 2014 11:25:52 +0200 Rasmus Villemoes wrote: > > Using seq_printf to print a simple string or a single character is a > > lot more expensive than it needs to be, since seq_puts and seq_putc > > exist. [] > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c [] > @@ -556,13 +556,13 @@ static int function_stat_cmp(void *p1, void *p2) > > static int function_stat_headers(struct seq_file *m) > > { > > #ifdef CONFIG_FUNCTION_GRAPH_TRACER > > - seq_printf(m, " Function " > > - "Hit Time Avg s^2\n" > > - " -------- " > > - "--- ---- --- ---\n"); > > + seq_puts(m, > > + " Function " "Hit Time Avg s^2\n" > > + " -------- " "--- ---- --- ---\n"); > > Please keep the original format. I know that it's considered bad form > to split strings like this, but I consider this one of the exceptions > to the rule. Why is that? btw: when the strings fragments are put on the same line, it's nicer to take out the intermediate joining " " bits too. I'd've probably used 2 seq_puts calls like: seq_puts(m, " Function Hit Time Avg s^2\n"); seq_puts(m, " -------- --- ---- --- ---\n");