From: Minfei Huang <mnfhuang@gmail.com>
To: tglx@linutronix.de, mingo@redhat.com
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Minfei Huang <mnfhuang@gmail.com>
Subject: [PATCH] x86/mm: Give the correct initail value to the pmd_idx
Date: Thu, 6 Nov 2014 13:41:53 +0800 [thread overview]
Message-ID: <1415252513-6453-1-git-send-email-mnfhuang@gmail.com> (raw)
The variable value is undefined from the stack eara. So it makes sense to
init the variable to run process correctly.
If the variable pmd_idx inits the value more than PTRS_PER_PMD, the
count may be smaller than the correct value, and the allocated page may
be not enough for pte entry.
The kernel may panic cause by the undefine variable which is allocated
from stack.
Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
---
arch/x86/mm/init_32.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c
index c8140e1..c23ab1e 100644
--- a/arch/x86/mm/init_32.c
+++ b/arch/x86/mm/init_32.c
@@ -137,6 +137,7 @@ page_table_range_init_count(unsigned long start, unsigned long end)
vaddr = start;
pgd_idx = pgd_index(vaddr);
+ pmd_idx = pmd_index(vaddr);
for ( ; (pgd_idx < PTRS_PER_PGD) && (vaddr != end); pgd_idx++) {
for (; (pmd_idx < PTRS_PER_PMD) && (vaddr != end);
--
1.8.3.1
next reply other threads:[~2014-11-06 5:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 5:41 Minfei Huang [this message]
2014-11-11 11:36 ` Minfei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415252513-6453-1-git-send-email-mnfhuang@gmail.com \
--to=mnfhuang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®