mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Peter Kümmel" <syntheticpp@gmx.net>
To: linux-kernel@vger.kernel.org
Cc: "Peter Kümmel" <syntheticpp@gmx.net>
Subject: [PATCH] kconfig: Fix warning "‘jump’ may be used uninitialized"
Date: Thu,  6 Nov 2014 13:03:00 +0100	[thread overview]
Message-ID: <1415275383-15301-1-git-send-email-syntheticpp@gmx.net> (raw)

Warning:
In file included from scripts/kconfig/zconf.tab.c:2537:0:
scripts/kconfig/menu.c: In function ‘get_symbol_str’:
scripts/kconfig/menu.c:590:18: warning: ‘jump’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     jump->offset = strlen(r->s);

Simplifies the test logic because (head && local) means (jump != 0)
and makes GCC happy when checking if the jump pointer was initialized.

Signed-off-by: Peter Kümmel <syntheticpp@gmx.net>
---
 scripts/kconfig/menu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index a26cc5d..72c9dba 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -548,7 +548,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop,
 {
 	int i, j;
 	struct menu *submenu[8], *menu, *location = NULL;
-	struct jump_key *jump;
+	struct jump_key *jump = NULL;
 
 	str_printf(r, _("Prompt: %s\n"), _(prop->text));
 	menu = prop->menu->parent;
@@ -586,7 +586,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop,
 		str_printf(r, _("  Location:\n"));
 		for (j = 4; --i >= 0; j += 2) {
 			menu = submenu[i];
-			if (head && location && menu == location)
+			if (jump && menu == location)
 				jump->offset = strlen(r->s);
 			str_printf(r, "%*c-> %s", j, ' ',
 				   _(menu_get_prompt(menu)));
-- 
1.9.1


             reply	other threads:[~2014-11-06 12:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-06 12:03 Peter Kümmel [this message]
2014-11-06 12:03 ` [PATCH] xconfig: Don't move focus when clicking on the search button Peter Kümmel
2014-11-06 12:03 ` [PATCH] xconfig: Set configuration strings on focus lost Peter Kümmel
2014-11-06 12:03 ` [PATCH] xconfig: Set keyboard focus to line edit whenever the search dialog opens Peter Kümmel
2014-11-06 12:36 ` [PATCH] kconfig: Fix warning "‘jump’ may be used uninitialized" Paul Bolle
2014-11-06 14:13   ` Aw: " Peter Kuemmel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415275383-15301-1-git-send-email-syntheticpp@gmx.net \
    --to=syntheticpp@gmx.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®