From: Tang Chen <tangchen@cn.fujitsu.com>
To: <akpm@linux-foundation.org>, <santosh.shilimkar@ti.com>,
<grygorii.strashko@ti.com>, <yinghai@kernel.org>,
<isimatu.yasuaki@jp.fujitsu.co>, <fabf@skynet.be>,
<nzimmer@sgi.com>, <wangnan0@huawei.com>,
<vdavydov@parallels.com>, <toshi.kani@hp.com>,
<phacht@linux.vnet.ibm.com>, <tj@kernel.org>,
<kirill.shutemov@linux.intel.com>, <riel@redhat.com>,
<luto@amacapital.net>, <hpa@linux.intel.com>,
<aarcange@redhat.com>, <qiuxishi@huawei.com>, <mgorman@suse.de>,
<rientjes@google.com>, <hannes@cmpxchg.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<tangchen@cn.fujitsu.com>, <miaox@cn.fujitsu.com>
Subject: [PATCH v2 0/2] Fix node meminfo and zoneinfo corruption.
Date: Fri, 7 Nov 2014 17:44:39 +0800 [thread overview]
Message-ID: <1415353481-3140-1-git-send-email-tangchen@cn.fujitsu.com> (raw)
There are two problems in memory hot-add progress:
1. When hot-adding a node without onlining any page, node meminfo corrupted:
# hot-add node2 (memory not onlined)
# cat /sys/device/system/node/node2/meminfo
Node 2 MemTotal: 33554432 kB /* corrupted */
Node 2 MemFree: 0 kB
Node 2 MemUsed: 33554432 kB
Node 2 Active: 0 kB
......
2. When onlining memory on node2, node2 zoneinfo and node3 meminfo corrupted:
# for ((i = 2048; i < 2064; i++)); do echo online_movable > /sys/devices/system/node/node2/memory$i/state; done
# cat /sys/devices/system/node/node2/meminfo
Node 2 MemTotal: 33554432 kB
Node 2 MemFree: 33549092 kB
Node 2 MemUsed: 5340 kB
......
# cat /sys/devices/system/node/node3/meminfo
Node 3 MemTotal: 0 kB
Node 3 MemFree: 248 kB /* corrupted, should be 0 */
Node 3 MemUsed: 0 kB
......
# cat /proc/zoneinfo
......
Node 2, zone Movable
......
spanned 8388608
present 16777216 /* corrupted, should be 8388608 */
managed 8388608
Change log v1 -> v2:
1. Replace patch 2/2 with a new one. It provides the simplest way to
fix problem 2.
Tang Chen (2):
mem-hotplug: Reset node managed pages when hot-adding a new pgdat.
mem-hotplug: Reset node present pages when hot-adding a new pgdat.
include/linux/bootmem.h | 1 +
mm/bootmem.c | 9 +++++----
mm/memory_hotplug.c | 24 ++++++++++++++++++++++++
mm/nobootmem.c | 8 +++++---
4 files changed, 35 insertions(+), 7 deletions(-)
--
1.8.3.1
next reply other threads:[~2014-11-07 9:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 9:44 Tang Chen [this message]
2014-11-07 9:44 ` [PATCH v2 1/2] mem-hotplug: Reset node managed pages when hot-adding a new pgdat Tang Chen
2014-11-07 9:44 ` [PATCH v2 2/2] mem-hotplug: Reset node present " Tang Chen
2014-11-10 0:27 ` Yasuaki Ishimatsu
2014-11-10 9:36 ` [PATCH v2 0/2] Fix node meminfo and zoneinfo corruption Xishi Qiu
2014-11-11 1:27 Tang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415353481-3140-1-git-send-email-tangchen@cn.fujitsu.com \
--to=tangchen@cn.fujitsu.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=grygorii.strashko@ti.com \
--cc=hannes@cmpxchg.org \
--cc=hpa@linux.intel.com \
--cc=isimatu.yasuaki@jp.fujitsu.co \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=mgorman@suse.de \
--cc=miaox@cn.fujitsu.com \
--cc=nzimmer@sgi.com \
--cc=phacht@linux.vnet.ibm.com \
--cc=qiuxishi@huawei.com \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=santosh.shilimkar@ti.com \
--cc=tj@kernel.org \
--cc=toshi.kani@hp.com \
--cc=vdavydov@parallels.com \
--cc=wangnan0@huawei.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®