From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752146AbaKGMSM (ORCPT ); Fri, 7 Nov 2014 07:18:12 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:30028 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751579AbaKGMSJ (ORCPT ); Fri, 7 Nov 2014 07:18:09 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfec7f5-b7f956d000005ed7-cd-545cb87d180b Content-transfer-encoding: 8BIT Message-id: <1415362683.31102.6.camel@AMDC1943> Subject: Re: [PATCH v9 2/4] amba: Don't unprepare the clocks if device driver wants IRQ safe runtime PM From: Krzysztof Kozlowski To: Pavel Machek Cc: "Rafael J. Wysocki" , Len Brown , Jonathan Corbet , Russell King , Dan Williams , Vinod Koul , Ulf Hansson , Alan Stern , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lars-Peter Clausen , Michal Simek , Kevin Hilman , Laurent Pinchart , Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz Date: Fri, 07 Nov 2014 13:18:03 +0100 In-reply-to: <20141107121320.GA20419@amd> References: <1415105570-7871-1-git-send-email-k.kozlowski@samsung.com> <1415105570-7871-3-git-send-email-k.kozlowski@samsung.com> <20141104201834.GC15071@amd> <1415176978.15850.11.camel@AMDC1943> <20141107121320.GA20419@amd> X-Mailer: Evolution 3.10.4-0ubuntu2 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHIsWRmVeSWpSXmKPExsVy+t/xq7q1O2JCDKbelLLYOGM9q8WTA+2M FtOnXmC0WD31L6vF082PmSzONr1ht1gyeT6rRefEJewWs6bsZbK4vGsOm8Xn3iOMFrcv81qs PXKX3eLdywiLu6eOslmcOX2J1WLC7wtsFsfXhlu87NvP4iDs0dLcw+Yxu2Mmq8fiPS+ZPDat 6mTzuHNtD5vH4r7JrB5L3hxi9dhytZ3FY/bdH4wefVtWMXqsWP2d3ePzJjmPvZ9/swTwRnHZ pKTmZJalFunbJXBlfH10hrHghEjFo5a/7A2Mb/m7GDk5JARMJLbdnc0KYYtJXLi3nq2LkYtD SGApo8T0De/AErwCghI/Jt9j6WLk4GAWkJc4cikbJMwsoC4xad4iZoj6z4wSOya2M0PU60ss +TsfrFdYIFOi5fgJdhCbTcBYYvPyJWwgtgjQnK19K8CamQVOs0rcapvPApJgEVCVaPgwhxHE 5hTQlFiybQMLxIZnjBK/Np5kBblCQkBZorHfbQKjwCwk981CuG8WkvsWMDKvYhRNLU0uKE5K zzXSK07MLS7NS9dLzs/dxAiJ0687GJceszrEKMDBqMTD+0AkJkSINbGsuDL3EKMEB7OSCC/7 VqAQb0piZVVqUX58UWlOavEhRiYOTqkGxqkPvn3MO8a4Rtw59bLLpw0fxZbdneb67T/DDAbT rvSXKRd8T87lXRv81mHS50uPeqzTDXZ2vb8v8EvVsfWPk0zOkTP3TN+0rFzr/ruUv2vd2p5s WW9jIefqz0Wt//dLFPx4sP7aQWM1W5FJwfefNWyWv2QllFm++8QWgQcxhQH6VrvFb097e1GJ pTgj0VCLuag4EQAqHtvssQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On pią, 2014-11-07 at 13:13 +0100, Pavel Machek wrote: > On Wed 2014-11-05 09:42:58, Krzysztof Kozlowski wrote: > > On wto, 2014-11-04 at 21:18 +0100, Pavel Machek wrote: > > > On Tue 2014-11-04 13:52:48, Krzysztof Kozlowski wrote: > > > > The AMBA bus driver defines runtime Power Management functions which > > > > disable and unprepare AMBA bus clock. This is problematic for runtime PM > > > > because unpreparing a clock might sleep so it is not interrupt safe. > > > > > > > > However some drivers may want to implement runtime PM functions in > > > > interrupt-safe way (see pm_runtime_irq_safe()). In such case the AMBA > > > > bus driver should only disable/enable the clock in runtime suspend and > > > > resume callbacks. > > > > > > > > > > > > > /* > > > > * Hooks to provide runtime PM of the pclk (bus clock). It is safe to > > > > * enable/disable the bus clock at runtime PM suspend/resume as this > > > > @@ -95,8 +102,14 @@ static int amba_pm_runtime_suspend(struct device *dev) > > > > struct amba_device *pcdev = to_amba_device(dev); > > > > int ret = pm_generic_runtime_suspend(dev); > > > > > > > > - if (ret == 0 && dev->driver) > > > > - clk_disable_unprepare(pcdev->pclk); > > > > + if (ret == 0 && dev->driver) { > > > > + pcdev->irq_safe = get_pm_runtime_irq_safe(dev); > > > > + > > > > + if (pcdev->irq_safe) > > > > + clk_disable(pcdev->pclk); > > > > + else > > > > + clk_disable_unprepare(pcdev->pclk); > > > > + } > > > > > > So you can handle the case of !pcdev->irq_safe. What is the penalty > > > for always assuming !pcdev->irq_safe? > > > > The penalty (for pl330 driver) would be that the runtime resume/suspend > > cannot happen from atomic context > > => pm_runtime_get_sync() cannot be called from atomic context > > => complete rework of runtime PM for pl330 DMA driver because now > > one of pm_runtime_get_sync() calls is in device_issue_pending > > callback which may not sleep. And by "rework" I also mean that > > I do not know how to do this... yet. > > I still don't get it. You say that you don't know how to handle > !pcdev->irq_safe case... Yet have code above that tries to handle it. > > If that case can't be sanely handled, I'd expect > BUG_ON(!pcdev->irq_safe). Hmmm... I could misunderstand your question. The amba/bus.c driver can handle both cases. However this varies for child drivers (which use these runtime PM callbacks too). For pl330 cannot handle non-irq-safe. Other drivers can. Is it the answer for your question? Best regards, Krzysztof