From: Andy Yan <andy.yan@rock-chips.com>
To: airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com,
rmk+kernel@arm.linux.org.uk
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Shawn Guo <shawn.guo@linaro.org>,
Andy yan <andy.yan@rock-chips.com>,
Josh Boyer <jwboyer@redhat.com>,
Sean Paul <seanpaul@chromium.org>,
Inki Dae <inki.dae@samsung.com>, Dave Airlie <airlied@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
Lucas Stach <l.stach@pengutronix.de>,
Zubair.Kakakhel@imgtec.com, djkurtz@google.com,
ykk@rock-chips.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org,
devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org,
jay.xu@rock-chips.com
Subject: [PATCH V5 4/7] dw-hdmi: return defer if can't get ddc i2c adapter
Date: Sat, 8 Nov 2014 13:30:33 +0800 [thread overview]
Message-ID: <1415424633-7616-1-git-send-email-andy.yan@rock-chips.com> (raw)
In-Reply-To: <1415424410-7364-1-git-send-email-andy.yan@rock-chips.com>
drm driver may probe before the i2c bus, so the driver should
defer probing untill it is avaliable
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
drivers/gpu/drm/bridge/dw_hdmi.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c
index df52921..e9e73a7 100644
--- a/drivers/gpu/drm/bridge/dw_hdmi.c
+++ b/drivers/gpu/drm/bridge/dw_hdmi.c
@@ -1503,8 +1503,11 @@ static int dw_hdmi_bind(struct device *dev, struct device *master, void *data)
ddc_node = of_parse_phandle(np, "ddc-i2c-bus", 0);
if (ddc_node) {
hdmi->ddc = of_find_i2c_adapter_by_node(ddc_node);
- if (!hdmi->ddc)
+ if (!hdmi->ddc) {
dev_dbg(hdmi->dev, "failed to read ddc node\n");
+ of_node_put(ddc_node);
+ return -EPROBE_DEFER;
+ }
of_node_put(ddc_node);
} else {
--
1.9.1
next prev parent reply other threads:[~2014-11-08 5:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-08 5:26 [PATCH V5 0/7]dw-hdmi: convert imx hdmi to bridge/dw-hdmi Andy Yan
2014-11-08 5:28 ` [PATCH V5 1/7] imx-drm: imx-hdmi: split imx soc specific code from imx-hdmi Andy Yan
2014-11-10 10:51 ` Zubair Lutfullah Kakakhel
2014-11-10 11:28 ` Andy Yan
2014-11-08 5:29 ` [PATCH V5 2/7] dw-hdmi: move imx-hdmi to bridge/dw-hdmi Andy Yan
2014-11-08 5:29 ` [PATCH V5 3/7] dw-hdmi: make checkpatch happy Andy Yan
2014-11-10 9:22 ` Zubair Lutfullah Kakakhel
2014-11-10 9:28 ` Andy Yan
2014-11-10 9:31 ` Andy Yan
2014-11-08 5:30 ` Andy Yan [this message]
2014-11-08 5:31 ` [PATCH V5 5/7] dw-hdmi: add support for multi byte register width access Andy Yan
2014-11-08 5:32 ` [PATCH V5 6/7] dw-hdmi: convert dw-hdmi to drm_bridge mode Andy Yan
2014-11-08 5:32 ` [PATCH V5 7/7] dt-bindings: add document for dw-hdmi Andy Yan
2014-11-10 9:17 ` Zubair Lutfullah Kakakhel
2014-11-10 9:44 ` Andy Yan
2014-11-10 9:53 ` Zubair Lutfullah Kakakhel
2014-11-10 9:59 ` Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415424633-7616-1-git-send-email-andy.yan@rock-chips.com \
--to=andy.yan@rock-chips.com \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@freescale.com \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=inki.dae@samsung.com \
--cc=jay.xu@rock-chips.com \
--cc=jwboyer@redhat.com \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=robh+dt@kernel.org \
--cc=seanpaul@chromium.org \
--cc=shawn.guo@linaro.org \
--cc=ykk@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®