mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: linux-kernel@vger.kernel.org
Cc: linux-pm@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org
Subject: [PATCH v6 46/48] x86: pmc_atom: Register power-off handler with kernel power-off handler
Date: Sun,  9 Nov 2014 17:43:03 -0800	[thread overview]
Message-ID: <1415583785-6980-47-git-send-email-linux@roeck-us.net> (raw)
In-Reply-To: <1415583785-6980-1-git-send-email-linux@roeck-us.net>

Register with kernel power-off handler instead of setting pm_power_off
directly. Register with low priority to reflect that the original code
only sets pm_power_off if it was not already set.

Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
v6:
- This patch: No change.
  Global: Replaced priority defines with enum.
v5:
- Rebase to v3.18-rc3
v4:
- No change
v3:
- Replace poweroff in all newly introduced variables and in text
  with power_off or power-off as appropriate
- Replace POWEROFF_PRIORITY_xxx with POWER_OFF_PRIORITY_xxx
v2:
- Use define to specify poweroff handler priority
- Use dev_warn instead of dev_err

 arch/x86/kernel/pmc_atom.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/pmc_atom.c b/arch/x86/kernel/pmc_atom.c
index 0ee5025e..acb4e78 100644
--- a/arch/x86/kernel/pmc_atom.c
+++ b/arch/x86/kernel/pmc_atom.c
@@ -20,6 +20,7 @@
 #include <linux/pci.h>
 #include <linux/device.h>
 #include <linux/debugfs.h>
+#include <linux/pm.h>
 #include <linux/seq_file.h>
 #include <linux/io.h>
 
@@ -92,7 +93,7 @@ static inline void pmc_reg_write(struct pmc_dev *pmc, int reg_offset, u32 val)
 	writel(val, pmc->regmap + reg_offset);
 }
 
-static void pmc_power_off(void)
+static void pmc_power_off(struct power_off_handler_block *this)
 {
 	u16	pm1_cnt_port;
 	u32	pm1_cnt_value;
@@ -109,6 +110,11 @@ static void pmc_power_off(void)
 	outl(pm1_cnt_value, pm1_cnt_port);
 }
 
+static struct power_off_handler_block pmc_power_off_hb = {
+	.handler = pmc_power_off,
+	.priority = POWER_OFF_PRIORITY_LOW,
+};
+
 static void pmc_hw_reg_setup(struct pmc_dev *pmc)
 {
 	/*
@@ -252,8 +258,12 @@ static int pmc_setup_dev(struct pci_dev *pdev)
 	acpi_base_addr &= ACPI_BASE_ADDR_MASK;
 
 	/* Install power off function */
-	if (acpi_base_addr != 0 && pm_power_off == NULL)
-		pm_power_off = pmc_power_off;
+	if (acpi_base_addr != 0) {
+		ret = register_power_off_handler(&pmc_power_off_hb);
+		if (ret)
+			dev_warn(&pdev->dev,
+				 "Failed to install power-off handler\n");
+	}
 
 	pci_read_config_dword(pdev, PMC_BASE_ADDR_OFFSET, &pmc->base_addr);
 	pmc->base_addr &= PMC_BASE_ADDR_MASK;
-- 
1.9.1


  parent reply	other threads:[~2014-11-10  1:45 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-10  1:42 [PATCH v6 00/48] kernel: Add support for power-off handler call chain Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 01/48] " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 02/48] memory: emif: Use API function to determine power-off capability Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 03/48] hibernate: Call have_kernel_power_off instead of checking pm_power_off Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 04/48] m68k: Replace mach_power_off with pm_power_off Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 05/48] mfd: as3722: Drop reference to pm_power_off from devicetree bindings Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 06/48] gpio-poweroff: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 07/48] qnap-poweroff: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 08/48] kernel: Move pm_power_off to common code Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 09/48] mfd: palmas: Register with kernel power-off handler Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 10/48] mfd: axp20x: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 11/48] mfd: retu: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 12/48] mfd: ab8500-sysctrl: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 13/48] mfd: max8907: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 14/48] mfd: tps80031: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 15/48] mfd: dm355evm_msp: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 16/48] mfd: tps6586x: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 17/48] mfd: tps65910: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 18/48] mfd: twl4030-power: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 19/48] mfd: rk808: Register power-off handler " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 20/48] mfd: rn5t618: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 21/48] ipmi: Register " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 22/48] power/reset: restart-poweroff: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 23/48] power/reset: gpio-poweroff: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 24/48] power/reset: as3722-poweroff: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 25/48] power/reset: qnap-poweroff: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 26/48] power/reset: msm-poweroff: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 27/48] power/reset: vexpress-poweroff: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 28/48] power/reset: at91-poweroff: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 29/48] power/reset: ltc2952-poweroff: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 30/48] x86: iris: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 31/48] x86: apm: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 32/48] x86: olpc: Register xo1 power-off handler " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 33/48] staging: nvec: Register " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 34/48] acpi: Register power-off handler " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 35/48] arm: Register " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 36/48] arm64: psci: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 37/48] avr32: atngw100: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 38/48] ia64: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 39/48] m68k: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 40/48] mips: " Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 41/48] powerpc: " Guenter Roeck
2014-11-11  7:42   ` Michael Ellerman
2014-11-11 10:42     ` Guenter Roeck
2014-11-10  1:42 ` [PATCH v6 42/48] sh: " Guenter Roeck
2014-11-10  1:43 ` [PATCH v6 43/48] x86: lguest: " Guenter Roeck
2014-11-10  1:43 ` [PATCH v6 44/48] x86: ce4100: " Guenter Roeck
2014-11-10  1:43 ` [PATCH v6 45/48] x86: intel-mid: Drop registration of dummy power-off handlers Guenter Roeck
2014-11-10  1:43 ` Guenter Roeck [this message]
2014-11-10  1:43 ` [PATCH v6 47/48] efi: Register power-off handler with kernel power-off handler Guenter Roeck
2014-11-10  1:43 ` [PATCH v6 48/48] kernel: Remove pm_power_off Guenter Roeck
2014-11-10  8:33 ` [PATCH v6 00/48] kernel: Add support for power-off handler call chain Pavel Machek
2014-11-10 14:12   ` Guenter Roeck
2014-11-11 18:20   ` Guenter Roeck
2014-11-11 18:50     ` Pavel Machek
2014-11-11 19:17       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415583785-6980-47-git-send-email-linux@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome