From: <dinguyen@opensource.altera.com>
To: <paulz@synopsys.com>, <balbi@ti.com>
Cc: <dinh.linux@gmail.com>, <swarren@wwwdotorg.org>,
<b.zolnierkie@samsung.com>, <matthijs@stdin.nl>,
<r.baldyga@samsung.com>, <jg1.han@samsung.com>,
<sachin.kamat@linaro.org>, <ben-linux@fluff.org>,
<dianders@chromium.org>, <kever.yang@rock-chips.com>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Dinh Nguyen <dinguyen@opensource.altera.com>
Subject: [PATCHv7 6/8] usb: dwc2: gadget: Do not fail probe if there isn't a clock node
Date: Tue, 11 Nov 2014 11:13:38 -0600 [thread overview]
Message-ID: <1415726020-19238-7-git-send-email-dinguyen@opensource.altera.com> (raw)
In-Reply-To: <1415726020-19238-1-git-send-email-dinguyen@opensource.altera.com>
From: Dinh Nguyen <dinguyen@opensource.altera.com>
Since the dwc2 hcd driver is currently not looking for a clock node during
init, we should not completely fail if there isn't a clock provided.
By assigning clk = NULL, this allows the driver, when configured for dual-role
mode, to be able to continue loading the host portion of the driver when
a clock node is not specified.
Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
---
v7: Reworked to use clk=NULL and remove the need to is IS_ERR(clk)
v6: none
v5: reworked to not access gadget functions from the hcd.
---
drivers/usb/dwc2/gadget.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 37c7916..367689b 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -3431,6 +3431,7 @@ int dwc2_gadget_init(struct dwc2_hsotg *hsotg, int irq)
hsotg->clk = devm_clk_get(dev, "otg");
if (IS_ERR(hsotg->clk)) {
+ hsotg->clk = NULL;
dev_err(dev, "cannot get otg clock\n");
return PTR_ERR(hsotg->clk);
}
--
2.0.3
next prev parent reply other threads:[~2014-11-11 17:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 17:13 [PATCHv7 0/8] usb: dwc2: Add support for dual-role dinguyen
2014-11-11 17:13 ` [PATCHv7 1/8] usb: dwc2: Update the gadget driver to use common dwc2_hsotg structure dinguyen
2014-11-21 2:08 ` Roy
2014-11-11 17:13 ` [PATCHv7 2/8] usb: dwc2: Move gadget probe function into platform code dinguyen
2014-11-11 17:13 ` [PATCHv7 3/8] usb: dwc2: convert to use dev_pm_ops API dinguyen
2014-11-14 20:40 ` Paul Zimmerman
2014-11-11 17:13 ` [PATCHv7 4/8] usb: dwc2: Initialize the USB core for peripheral mode dinguyen
2014-11-11 17:13 ` [PATCHv7 5/8] usb: dwc2: Update common interrupt handler to call gadget interrupt handler dinguyen
2014-11-14 20:52 ` Paul Zimmerman
2014-11-11 17:13 ` dinguyen [this message]
2014-11-14 21:01 ` [PATCHv7 6/8] usb: dwc2: gadget: Do not fail probe if there isn't a clock node Paul Zimmerman
2014-11-14 21:07 ` Felipe Balbi
2014-11-11 17:13 ` [PATCHv7 7/8] usb: dwc2: move usb_disabled() call to host driver only dinguyen
2014-11-14 20:58 ` Paul Zimmerman
2014-11-11 17:13 ` [PATCHv7 8/8] usb: dwc2: Update Kconfig to support dual-role dinguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415726020-19238-7-git-send-email-dinguyen@opensource.altera.com \
--to=dinguyen@opensource.altera.com \
--cc=b.zolnierkie@samsung.com \
--cc=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=dianders@chromium.org \
--cc=dinh.linux@gmail.com \
--cc=jg1.han@samsung.com \
--cc=kever.yang@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthijs@stdin.nl \
--cc=paulz@synopsys.com \
--cc=r.baldyga@samsung.com \
--cc=sachin.kamat@linaro.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome