From: Tang Chen <tangchen@cn.fujitsu.com>
To: <akpm@linux-foundation.org>, <grygorii.strashko@ti.com>,
<yinghai@kernel.org>, <isimatu.yasuaki@jp.fujitsu.com>,
<fabf@skynet.be>, <nzimmer@sgi.com>, <wangnan0@huawei.com>,
<vdavydov@parallels.com>, <toshi.kani@hp.com>,
<phacht@linux.vnet.ibm.com>, <tj@kernel.org>,
<kirill.shutemov@linux.intel.com>, <riel@redhat.com>,
<luto@amacapital.net>, <hpa@linux.intel.com>,
<aarcange@redhat.com>, <qiuxishi@huawei.com>, <mgorman@suse.de>,
<rientjes@google.com>, <hannes@cmpxchg.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<tangchen@cn.fujitsu.com>, <stable@vger.kernel.org.#.3.16+>
Subject: [PATCH v3 2/2] mem-hotplug: Reset node present pages when hot-adding a new pgdat.
Date: Wed, 12 Nov 2014 16:37:14 +0800 [thread overview]
Message-ID: <1415781434-20230-3-git-send-email-tangchen@cn.fujitsu.com> (raw)
In-Reply-To: <1415781434-20230-1-git-send-email-tangchen@cn.fujitsu.com>
When memory is hot-added, all the memory is in offline state. So
clear all zones' present_pages because they will be updated in
online_pages() and offline_pages(). Otherwise, /proc/zoneinfo
will corrupt:
When the memory of node2 is offline:
# cat /proc/zoneinfo
......
Node 2, zone Movable
......
spanned 8388608
present 8388608
managed 0
When we online memory on node2:
# cat /proc/zoneinfo
......
Node 2, zone Movable
......
spanned 8388608
present 16777216
managed 8388608
Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Cc: stable@vger.kernel.org # 3.16+
---
mm/memory_hotplug.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 8aba12b..d0c9b7c 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -1067,6 +1067,16 @@ out:
}
#endif /* CONFIG_MEMORY_HOTPLUG_SPARSE */
+static void reset_node_present_pages(pg_data_t *pgdat)
+{
+ struct zone *z;
+
+ for (z = pgdat->node_zones; z < pgdat->node_zones + MAX_NR_ZONES; z++)
+ z->present_pages = 0;
+
+ pgdat->node_present_pages = 0;
+}
+
/* we are OK calling __meminit stuff here - we have CONFIG_MEMORY_HOTPLUG */
static pg_data_t __ref *hotadd_new_pgdat(int nid, u64 start)
{
@@ -1105,6 +1115,13 @@ static pg_data_t __ref *hotadd_new_pgdat(int nid, u64 start)
*/
reset_node_managed_pages(pgdat);
+ /*
+ * When memory is hot-added, all the memory is in offline state. So
+ * clear all zones' present_pages because they will be updated in
+ * online_pages() and offline_pages().
+ */
+ reset_node_present_pages(pgdat);
+
return pgdat;
}
--
1.8.3.1
prev parent reply other threads:[~2014-11-12 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 8:37 [PATCH v3 0/2] Fix node meminfo and zoneinfo corruption Tang Chen
2014-11-12 8:37 ` [PATCH v3 1/2] mem-hotplug: Reset node managed pages when hot-adding a new pgdat Tang Chen
2014-11-12 8:37 ` Tang Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415781434-20230-3-git-send-email-tangchen@cn.fujitsu.com \
--to=tangchen@cn.fujitsu.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=grygorii.strashko@ti.com \
--cc=hannes@cmpxchg.org \
--cc=hpa@linux.intel.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=mgorman@suse.de \
--cc=nzimmer@sgi.com \
--cc=phacht@linux.vnet.ibm.com \
--cc=qiuxishi@huawei.com \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=stable@vger.kernel.org.#.3.16+ \
--cc=tj@kernel.org \
--cc=toshi.kani@hp.com \
--cc=vdavydov@parallels.com \
--cc=wangnan0@huawei.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®