mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
	Fabio Estevam <festevam@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH] drivers/base: cacheinfo: remove noisy error boot message
Date: Wed, 12 Nov 2014 14:42:53 +0000	[thread overview]
Message-ID: <1415803373-7429-1-git-send-email-sudeep.holla@arm.com> (raw)

On systems that don't support cacheinfo, this error message can be
considered noisy and irrelevant. The error messages can be added to
the functions that architectures implement overiding the weak default
definition if really required.

This patch removes the concerned error message in the generic code.

Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Reported-by: Fabio Estevam <festevam@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/base/cacheinfo.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Hi Greg,

Since I always tested the series only on the architectures supporting
cacheinfo, I failed to see that this error message is thrown out at the
boot time if the architecture doesn't support it.

Can you pick up this small fix to avoid noisy error message ?

Regards,
Sudeep

diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c
index 8ed4ea1f3716..6e64563361f0 100644
--- a/drivers/base/cacheinfo.c
+++ b/drivers/base/cacheinfo.c
@@ -520,10 +520,8 @@ static int __init cacheinfo_sysfs_init(void)
 
 	for_each_online_cpu(cpu) {
 		rc = detect_cache_attributes(cpu);
-		if (rc) {
-			pr_err("error detecting cacheinfo..cpu%d\n", cpu);
+		if (rc)
 			goto out;
-		}
 		rc = cache_add_dev(cpu);
 		if (rc) {
 			free_cache_attributes(cpu);
-- 
1.9.1


                 reply	other threads:[~2014-11-12 14:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415803373-7429-1-git-send-email-sudeep.holla@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®