From: Matt Fleming <matt.fleming@intel.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Borislav Petkov <bp@suse.de>,
the arch/x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: BUG() at boot in __phys_addr with DEBUG_VIRTUAL
Date: Thu, 13 Nov 2014 13:08:03 +0000 [thread overview]
Message-ID: <1415884083.14686.439.camel@mfleming-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <54637AD5.6060300@intel.com>
On Wed, 2014-11-12 at 07:20 -0800, Dave Hansen wrote:
>
> The path that we're actually hitting this from is:
>
> > __split_large_page(struct cpa_data *cpa, pte_t *kpte, unsigned long
> ...
> > if (pfn_range_is_mapped(PFN_DOWN(__pa(address)),
> > PFN_DOWN(__pa(address)) + 1))
> > split_page_count(level);
I'm sure I'm just being dumb, but I can't for the life of me work out
why we need to calculate the physical address from the virtual address
at this point - we should already have that information.
> So perhaps efi_map_region() is handing an address from the EFI identity
> map down in here. __pa() gets called on it, but that fails since __pa()
> only works on the *KERNEL* identity map.
Yep, sounds right.
next prev parent reply other threads:[~2014-11-13 13:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 23:19 Dave Hansen
2014-11-11 23:47 ` Borislav Petkov
2014-11-12 9:24 ` Matt Fleming
2014-11-12 14:57 ` Dave Hansen
2014-11-12 15:11 ` Borislav Petkov
2014-11-12 15:20 ` Dave Hansen
2014-11-12 17:25 ` Borislav Petkov
2014-11-13 10:36 ` Matt Fleming
2014-12-09 10:35 ` Borislav Petkov
2014-11-13 13:08 ` Matt Fleming [this message]
2015-01-27 21:37 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415884083.14686.439.camel@mfleming-mobl1.ger.corp.intel.com \
--to=matt.fleming@intel.com \
--cc=bp@suse.de \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®