From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: "Lothar Waßmann" <LW@KARO-electronics.de>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Henrik Rydberg" <rydberg@euromail.se>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Markus Pargmann <mpa@pengutronix.de>,
Maxime Ripard <maxime.ripard@free-electrons.com>
Subject: [PATCH v2 3/4] input: ft5x06: Allow to set the maximum axes value through the DT
Date: Thu, 13 Nov 2014 15:06:57 +0100 [thread overview]
Message-ID: <1415887618-29844-4-git-send-email-maxime.ripard@free-electrons.com> (raw)
In-Reply-To: <1415887618-29844-1-git-send-email-maxime.ripard@free-electrons.com>
Currently the driver relies on some obscure and undocumented register to set
the maximum axis value.
The reported value is way too high to be meaningful, which confuses some
userspace tools like QT's evdevtouch plugin which try to scale the reported
events to the maximum values.
Use the values from the DT to set meaningful values.
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
drivers/input/touchscreen/edt-ft5x06.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
index ee3434f1e949..3ebc1a7e46c5 100644
--- a/drivers/input/touchscreen/edt-ft5x06.c
+++ b/drivers/input/touchscreen/edt-ft5x06.c
@@ -37,6 +37,7 @@
#include <linux/gpio.h>
#include <linux/of_gpio.h>
#include <linux/input/mt.h>
+#include <linux/input/touchscreen.h>
#include <linux/input/edt-ft5x06.h>
#define MAX_SUPPORT_POINTS 5
@@ -1042,6 +1043,10 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client,
0, tsdata->num_x * 64 - 1, 0, 0);
input_set_abs_params(input, ABS_MT_POSITION_Y,
0, tsdata->num_y * 64 - 1, 0, 0);
+
+ if (!pdata)
+ touchscreen_parse_of_params(input);
+
error = input_mt_init_slots(input, MAX_SUPPORT_POINTS, 0);
if (error) {
dev_err(&client->dev, "Unable to init MT slots.\n");
--
2.1.1
next prev parent reply other threads:[~2014-11-13 14:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 14:06 [PATCH v2 0/4] input: ft5x06: Fix userspace reported maximum value Maxime Ripard
2014-11-13 14:06 ` [PATCH v2 1/4] input: touchscreen: of: Use input_set_abs_params Maxime Ripard
2014-11-13 14:06 ` [PATCH v2 2/4] input: touchscreen: of: Register multitouch axes Maxime Ripard
2014-11-13 14:06 ` Maxime Ripard [this message]
2014-11-13 14:06 ` [PATCH v2 4/4] input: edt-ft5x06: Remove EV_SYN event report Maxime Ripard
2015-02-23 21:49 ` [PATCH v2 0/4] input: ft5x06: Fix userspace reported maximum value Markus Pargmann
2015-02-24 16:55 ` Maxime Ripard
2015-02-26 15:26 ` Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415887618-29844-4-git-send-email-maxime.ripard@free-electrons.com \
--to=maxime.ripard@free-electrons.com \
--cc=LW@KARO-electronics.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®