From: lukasz.anaczkowski@intel.com
To: m.chehab@samsung.com, dougthompson@xmission.com
Cc: bp@alien8.de, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, Jim Snow <jim.m.snow@intel.com>,
Jim Snow <jim.snow@intel.com>,
Lukasz Anaczkowski <lukasz.anaczkowski@intel.com>
Subject: [PATCH 1/2] sb_edac: Fix off-by-one error in number of channels
Date: Tue, 18 Nov 2014 14:51:08 +0100 [thread overview]
Message-ID: <1416318669-96322-2-git-send-email-lukasz.anaczkowski@intel.com> (raw)
In-Reply-To: <1416318669-96322-1-git-send-email-lukasz.anaczkowski@intel.com>
From: Jim Snow <jim.m.snow@intel.com>
This prevented edac sysfs code from properly handling 6 channels
per memory controller.
Signed-off-by: Jim Snow <jim.snow@intel.com>
Signed-off-by: Lukasz Anaczkowski <lukasz.anaczkowski@intel.com>
---
drivers/edac/edac_mc_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c
index a6cd361..670d282 100644
--- a/drivers/edac/edac_mc_sysfs.c
+++ b/drivers/edac/edac_mc_sysfs.c
@@ -372,7 +372,7 @@ static int edac_create_csrow_object(struct mem_ctl_info *mci,
{
int err, chan;
- if (csrow->nr_channels >= EDAC_NR_CHANNELS)
+ if (csrow->nr_channels > EDAC_NR_CHANNELS)
return -ENODEV;
csrow->dev.type = &csrow_attr_type;
--
2.0.4
--------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.
next prev parent reply other threads:[~2014-11-18 13:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 13:51 [PATCH 0/2] sb_edac: two bugfixes lukasz.anaczkowski
2014-11-18 13:51 ` lukasz.anaczkowski [this message]
2014-11-18 13:51 ` [PATCH 2/2] sb_edac: Fix erroneous bytes->gigabytes conversion lukasz.anaczkowski
2014-12-02 19:09 ` [PATCH 0/2] sb_edac: two bugfixes Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416318669-96322-2-git-send-email-lukasz.anaczkowski@intel.com \
--to=lukasz.anaczkowski@intel.com \
--cc=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=jim.m.snow@intel.com \
--cc=jim.snow@intel.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®