From: Mariusz Gorski <marius.gorski@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Willy Tarreau <w@1wt.eu>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 8/9] staging: panel: Remove more magic number comparison
Date: Wed, 19 Nov 2014 21:38:50 +0100 [thread overview]
Message-ID: <1416429531-11088-9-git-send-email-marius.gorski@gmail.com> (raw)
In-Reply-To: <1416429531-11088-1-git-send-email-marius.gorski@gmail.com>
Use a defined value instead of magic number comparison
for checking whether a module param value has been set.
Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com>
---
v2: Don't introduce new macros for param value check
drivers/staging/panel/panel.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 0bdb447..19f6767 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -1494,17 +1494,17 @@ static void lcd_init(void)
}
/* Overwrite with module params set on loading */
- if (lcd_height > -1)
+ if (lcd_height != NOT_SET)
lcd.height = lcd_height;
- if (lcd_width > -1)
+ if (lcd_width != NOT_SET)
lcd.width = lcd_width;
- if (lcd_bwidth > -1)
+ if (lcd_bwidth != NOT_SET)
lcd.bwidth = lcd_bwidth;
- if (lcd_hwidth > -1)
+ if (lcd_hwidth != NOT_SET)
lcd.hwidth = lcd_hwidth;
- if (lcd_charset > -1)
+ if (lcd_charset != NOT_SET)
lcd.charset = lcd_charset;
- if (lcd_proto > -1)
+ if (lcd_proto != NOT_SET)
lcd.proto = lcd_proto;
if (lcd_e_pin != PIN_NOT_SET)
lcd.pins.e = lcd_e_pin;
@@ -2304,16 +2304,16 @@ static int __init panel_init_module(void)
* Overwrite selection with module param values (both keypad and lcd),
* where the deprecated params have lower prio.
*/
- if (keypad_enabled > -1)
+ if (keypad_enabled != NOT_SET)
selected_keypad_type = keypad_enabled;
- if (keypad_type > -1)
+ if (keypad_type != NOT_SET)
selected_keypad_type = keypad_type;
keypad.enabled = (selected_keypad_type > 0);
- if (lcd_enabled > -1)
+ if (lcd_enabled != NOT_SET)
selected_lcd_type = lcd_enabled;
- if (lcd_type > -1)
+ if (lcd_type != NOT_SET)
selected_lcd_type = lcd_type;
lcd.enabled = (selected_lcd_type > 0);
--
2.1.3
next prev parent reply other threads:[~2014-11-19 20:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 20:38 [PATCH v2 0/9] staging: panel: Refactor panel initialization Mariusz Gorski
2014-11-19 20:38 ` [PATCH v2 1/9] staging: panel: Set default parport module param value Mariusz Gorski
2014-11-19 20:38 ` [PATCH v2 2/9] staging: panel: Call init function directly Mariusz Gorski
2014-11-19 20:38 ` [PATCH v2 3/9] staging: panel: Remove magic numbers Mariusz Gorski
2014-11-19 20:38 ` [PATCH v2 4/9] staging: panel: Use defined value or checking module params state Mariusz Gorski
2014-11-19 21:10 ` Willy Tarreau
2014-11-26 21:58 ` Greg Kroah-Hartman
2014-11-27 13:26 ` Mariusz Gorski
2014-11-27 15:24 ` Greg Kroah-Hartman
2014-11-27 15:57 ` Greg Kroah-Hartman
2014-11-27 16:14 ` Willy Tarreau
2014-11-27 16:28 ` Greg Kroah-Hartman
2014-11-27 19:50 ` Mariusz Gorski
2014-11-27 21:05 ` Willy Tarreau
2014-11-27 21:10 ` Fabio Estevam
2014-11-28 20:32 ` Greg Kroah-Hartman
2014-11-28 20:57 ` Mariusz Gorski
2014-11-28 22:14 ` Greg Kroah-Hartman
2014-11-19 20:38 ` [PATCH v2 5/9] staging: panel: Start making module params read-only Mariusz Gorski
2014-11-19 20:38 ` [PATCH v2 6/9] staging: panel: Make two more " Mariusz Gorski
2014-11-19 21:11 ` Willy Tarreau
2014-11-19 20:38 ` [PATCH v2 7/9] staging: panel: Refactor LCD init code Mariusz Gorski
2014-11-19 21:11 ` Willy Tarreau
2014-11-19 20:38 ` Mariusz Gorski [this message]
2014-11-19 21:11 ` [PATCH v2 8/9] staging: panel: Remove more magic number comparison Willy Tarreau
2014-11-19 20:38 ` [PATCH v2 9/9] staging: panel: Move LCD-related state into struct lcd Mariusz Gorski
2014-11-19 21:12 ` [PATCH v2 0/9] staging: panel: Refactor panel initialization Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416429531-11088-9-git-send-email-marius.gorski@gmail.com \
--to=marius.gorski@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®