From: Paolo Bonzini <pbonzini@redhat.com>
To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: wanpeng.li@linux.intel.com, namit@cs.technion.ac.il, hpa@linux.intel.com
Subject: [CFT PATCH v2 1/2] kvm: x86: mask out XSAVES
Date: Mon, 24 Nov 2014 17:43:33 +0100 [thread overview]
Message-ID: <1416847414-22253-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1416847414-22253-1-git-send-email-pbonzini@redhat.com>
This feature is not supported inside KVM guests yet, because we do not emulate
MSR_IA32_XSS. Mask it out.
Cc: Nadav Amit <namit@cs.technion.ac.il>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
arch/x86/kvm/cpuid.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
index 20d83217fb1d..a4f5ac46226c 100644
--- a/arch/x86/kvm/cpuid.c
+++ b/arch/x86/kvm/cpuid.c
@@ -320,6 +320,10 @@ static inline int __do_cpuid_ent(struct kvm_cpuid_entry2 *entry, u32 function,
F(ADX) | F(SMAP) | F(AVX512F) | F(AVX512PF) | F(AVX512ER) |
F(AVX512CD);
+ /* cpuid 0xD.1.eax */
+ const u32 kvm_supported_word10_x86_features =
+ F(XSAVEOPT) | F(XSAVEC) | F(XGETBV1);
+
/* all calls to cpuid_count() should be made on the same cpu */
get_cpu();
@@ -456,13 +460,18 @@ static inline int __do_cpuid_ent(struct kvm_cpuid_entry2 *entry, u32 function,
entry->eax &= supported;
entry->edx &= supported >> 32;
entry->flags |= KVM_CPUID_FLAG_SIGNIFCANT_INDEX;
+ if (!supported)
+ break;
+
for (idx = 1, i = 1; idx < 64; ++idx) {
u64 mask = ((u64)1 << idx);
if (*nent >= maxnent)
goto out;
do_cpuid_1_ent(&entry[i], function, idx);
- if (entry[i].eax == 0 || !(supported & mask))
+ if (idx == 1)
+ entry[i].eax &= kvm_supported_word10_x86_features;
+ else if (entry[i].eax == 0 || !(supported & mask))
continue;
entry[i].flags |=
KVM_CPUID_FLAG_SIGNIFCANT_INDEX;
--
1.8.3.1
next prev parent reply other threads:[~2014-11-24 16:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 16:43 [CFT PATCH v2 0/2] KVM: support XSAVES usage in the host Paolo Bonzini
2014-11-24 16:43 ` Paolo Bonzini [this message]
2014-11-24 16:43 ` [CFT PATCH v2 2/2] KVM: x86: " Paolo Bonzini
2014-11-26 12:07 ` Radim Krčmář
2014-11-26 13:13 ` Paolo Bonzini
2014-11-26 13:53 ` Radim Krčmář
2014-11-26 13:57 ` Paolo Bonzini
2014-11-26 14:42 ` Radim Krčmář
2014-11-26 16:26 ` Paolo Bonzini
2014-11-26 17:31 ` Radim Krčmář
2014-12-03 14:23 ` Nadav Amit
2014-12-03 14:26 ` Paolo Bonzini
2014-12-03 18:45 ` Radim Krčmář
2014-12-04 13:43 ` Paolo Bonzini
2014-12-04 13:52 ` Radim Krčmář
2014-11-25 10:13 ` [CFT PATCH v2 0/2] KVM: " Wanpeng Li
2014-11-25 10:36 ` Paolo Bonzini
2014-11-25 14:05 ` Nadav Amit
2014-11-25 14:17 ` Paolo Bonzini
2014-11-25 14:50 ` Nadav Amit
2014-11-26 1:24 ` Wanpeng Li
2014-11-26 9:00 ` Nadav Amit
2014-11-26 8:47 ` Wanpeng Li
2014-11-26 12:54 ` Paolo Bonzini
2014-12-02 5:16 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416847414-22253-2-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=hpa@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namit@cs.technion.ac.il \
--cc=wanpeng.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®