mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: "David Miller" <davem@davemloft.net>,
	cornelia.huck@de.ibm.com, rusty@au1.ibm.com, nab@linux-iscsi.org,
	pbonzini@redhat.com, "Rusty Russell" <rusty@rustcorp.com.au>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Alexei Starovoitov" <ast@plumgrid.com>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	=?UTF-8?q?Piotr=20Kr=C3=B3l?= <piotr.krol@3mdeb.com>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Andy Grover" <agrover@redhat.com>,
	"stephen hemminger" <stephen@networkplumber.org>,
	"Anup Patel" <anup.patel@linaro.org>,
	linux-api@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: [PATCH v4 40/42] virtio_scsi: export to userspace
Date: Tue, 25 Nov 2014 18:44:16 +0200	[thread overview]
Message-ID: <1416933600-21398-41-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1416933600-21398-1-git-send-email-mst@redhat.com>

Replace uXX by __uXX and _packed by __attribute((packed))
as seems to be the norm for userspace headers.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/uapi/linux/virtio_scsi.h | 74 ++++++++++++++++++++--------------------
 include/uapi/linux/Kbuild        |  1 +
 2 files changed, 38 insertions(+), 37 deletions(-)

diff --git a/include/uapi/linux/virtio_scsi.h b/include/uapi/linux/virtio_scsi.h
index af44864..42b9370 100644
--- a/include/uapi/linux/virtio_scsi.h
+++ b/include/uapi/linux/virtio_scsi.h
@@ -34,78 +34,78 @@
 
 /* SCSI command request, followed by data-out */
 struct virtio_scsi_cmd_req {
-	u8 lun[8];		/* Logical Unit Number */
+	__u8 lun[8];		/* Logical Unit Number */
 	__virtio64 tag;		/* Command identifier */
-	u8 task_attr;		/* Task attribute */
-	u8 prio;		/* SAM command priority field */
-	u8 crn;
-	u8 cdb[VIRTIO_SCSI_CDB_SIZE];
-} __packed;
+	__u8 task_attr;		/* Task attribute */
+	__u8 prio;		/* SAM command priority field */
+	__u8 crn;
+	__u8 cdb[VIRTIO_SCSI_CDB_SIZE];
+} __attribute__((packed));
 
 /* SCSI command request, followed by protection information */
 struct virtio_scsi_cmd_req_pi {
-	u8 lun[8];		/* Logical Unit Number */
+	__u8 lun[8];		/* Logical Unit Number */
 	__virtio64 tag;		/* Command identifier */
-	u8 task_attr;		/* Task attribute */
-	u8 prio;		/* SAM command priority field */
-	u8 crn;
+	__u8 task_attr;		/* Task attribute */
+	__u8 prio;		/* SAM command priority field */
+	__u8 crn;
 	__virtio32 pi_bytesout;	/* DataOUT PI Number of bytes */
 	__virtio32 pi_bytesin;		/* DataIN PI Number of bytes */
-	u8 cdb[VIRTIO_SCSI_CDB_SIZE];
-} __packed;
+	__u8 cdb[VIRTIO_SCSI_CDB_SIZE];
+} __attribute__((packed));
 
 /* Response, followed by sense data and data-in */
 struct virtio_scsi_cmd_resp {
 	__virtio32 sense_len;		/* Sense data length */
 	__virtio32 resid;		/* Residual bytes in data buffer */
 	__virtio16 status_qualifier;	/* Status qualifier */
-	u8 status;		/* Command completion status */
-	u8 response;		/* Response values */
-	u8 sense[VIRTIO_SCSI_SENSE_SIZE];
-} __packed;
+	__u8 status;		/* Command completion status */
+	__u8 response;		/* Response values */
+	__u8 sense[VIRTIO_SCSI_SENSE_SIZE];
+} __attribute__((packed));
 
 /* Task Management Request */
 struct virtio_scsi_ctrl_tmf_req {
 	__virtio32 type;
 	__virtio32 subtype;
-	u8 lun[8];
+	__u8 lun[8];
 	__virtio64 tag;
-} __packed;
+} __attribute__((packed));
 
 struct virtio_scsi_ctrl_tmf_resp {
-	u8 response;
-} __packed;
+	__u8 response;
+} __attribute__((packed));
 
 /* Asynchronous notification query/subscription */
 struct virtio_scsi_ctrl_an_req {
 	__virtio32 type;
-	u8 lun[8];
+	__u8 lun[8];
 	__virtio32 event_requested;
-} __packed;
+} __attribute__((packed));
 
 struct virtio_scsi_ctrl_an_resp {
 	__virtio32 event_actual;
-	u8 response;
-} __packed;
+	__u8 response;
+} __attribute__((packed));
 
 struct virtio_scsi_event {
 	__virtio32 event;
-	u8 lun[8];
+	__u8 lun[8];
 	__virtio32 reason;
-} __packed;
+} __attribute__((packed));
 
 struct virtio_scsi_config {
-	u32 num_queues;
-	u32 seg_max;
-	u32 max_sectors;
-	u32 cmd_per_lun;
-	u32 event_info_size;
-	u32 sense_size;
-	u32 cdb_size;
-	u16 max_channel;
-	u16 max_target;
-	u32 max_lun;
-} __packed;
+	__u32 num_queues;
+	__u32 seg_max;
+	__u32 max_sectors;
+	__u32 cmd_per_lun;
+	__u32 event_info_size;
+	__u32 sense_size;
+	__u32 cdb_size;
+	__u16 max_channel;
+	__u16 max_target;
+	__u32 max_lun;
+} __attribute__((packed));
 
 /* Feature Bits */
 #define VIRTIO_SCSI_F_INOUT                    0
diff --git a/include/uapi/linux/Kbuild b/include/uapi/linux/Kbuild
index 44a5581..e61947c 100644
--- a/include/uapi/linux/Kbuild
+++ b/include/uapi/linux/Kbuild
@@ -428,6 +428,7 @@ header-y += virtio_net.h
 header-y += virtio_pci.h
 header-y += virtio_ring.h
 header-y += virtio_rng.h
+header-y += virtio_scsi.h
 header=y += vm_sockets.h
 header-y += vt.h
 header-y += wait.h
-- 
MST


  parent reply	other threads:[~2014-11-25 16:44 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-25 16:41 [PATCH v4 00/42] linux: towards virtio-1 guest support Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 01/42] virtio: use u32, not bitmap for struct virtio_device's features Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 02/42] virtio: add support for 64 bit features Michael S. Tsirkin
2014-11-26 16:48   ` Greg Kurz
2014-11-26 16:56     ` Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 03/42] virtio: add virtio 1.0 feature bit Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 04/42] virtio: disable virtio 1.0 in transports Michael S. Tsirkin
2014-11-25 17:29   ` Cornelia Huck
2014-11-25 21:20     ` Michael S. Tsirkin
2014-11-26  9:09       ` Cornelia Huck
2014-11-27 10:54         ` Michael S. Tsirkin
2014-11-27 11:02           ` Cornelia Huck
2014-11-27 11:06             ` Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 05/42] virtio: memory access APIs Michael S. Tsirkin
2014-11-25 17:42   ` Cornelia Huck
2014-11-25 16:41 ` [PATCH v4 06/42] virtio_ring: switch to new " Michael S. Tsirkin
2014-11-25 16:41 ` [PATCH v4 07/42] virtio_config: endian conversion for v1.0 Michael S. Tsirkin
2014-11-25 17:45   ` Cornelia Huck
2014-11-25 21:36     ` Michael S. Tsirkin
2014-11-26  9:13       ` Cornelia Huck
2014-11-25 16:41 ` [PATCH v4 08/42] virtio: allow transports to get avail/used addresses Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 09/42] virtio: set FEATURES_OK Michael S. Tsirkin
2014-11-25 17:48   ` Cornelia Huck
2014-11-25 21:38     ` Michael S. Tsirkin
2014-11-26  9:18       ` Cornelia Huck
2014-11-25 16:42 ` [PATCH v4 10/42] virtio: simplify feature bit handling Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 11/42] virtio: add legacy feature table support Michael S. Tsirkin
2014-11-25 17:53   ` Cornelia Huck
2014-11-25 21:39     ` Michael S. Tsirkin
2014-11-26  9:19       ` Cornelia Huck
2014-11-25 16:42 ` [PATCH v4 12/42] virtio_net: v1.0 endianness Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 13/42] virtio_blk: v1.0 support Michael S. Tsirkin
2014-11-25 17:55   ` Cornelia Huck
2014-11-25 21:43     ` Michael S. Tsirkin
2014-11-26 15:40       ` David Hildenbrand
2014-11-26 15:48         ` Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 14/42] KVM: s390: Set virtio-ccw transport revision Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 15/42] KVM: s390: virtio-ccw revision 1 SET_VQ Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 16/42] KVM: s390 allow virtio_ccw status writes to fail Michael S. Tsirkin
2014-11-25 17:57   ` Cornelia Huck
2014-11-25 16:42 ` [PATCH v4 17/42] KVM: s390: enable virtio-ccw revision 1 Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 18/42] virtio_blk: make serial attribute static Michael S. Tsirkin
2014-11-26  8:48   ` Gerd Hoffmann
2014-11-26  9:50   ` Cornelia Huck
2014-11-25 16:42 ` [PATCH v4 19/42] virtio_blk: fix race at module removal Michael S. Tsirkin
2014-11-26  9:53   ` Cornelia Huck
2014-11-25 16:42 ` [PATCH v4 20/42] virtio_net: pass vi around Michael S. Tsirkin
2014-11-26 12:35   ` Cornelia Huck
2014-11-25 16:42 ` [PATCH v4 21/42] virtio_net: get rid of virtio_net_hdr/skb_vnet_hdr Michael S. Tsirkin
2014-11-26 12:50   ` Cornelia Huck
2014-11-26 13:11     ` Michael S. Tsirkin
2014-11-25 16:42 ` [PATCH v4 22/42] virtio_net: stricter short buffer length checks Michael S. Tsirkin
2014-11-26 13:00   ` Cornelia Huck
2014-11-25 16:43 ` [PATCH v4 23/42] virtio_net: bigger header when VERSION_1 is set Michael S. Tsirkin
2014-11-26 13:04   ` Cornelia Huck
2014-11-25 16:43 ` [PATCH v4 24/42] virtio_net: enable v1.0 support Michael S. Tsirkin
2014-11-26 13:08   ` Cornelia Huck
2014-11-26 13:28     ` Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 25/42] vhost: add memory access wrappers Michael S. Tsirkin
2014-11-26 13:54   ` Cornelia Huck
2014-11-26 14:05     ` Michael S. Tsirkin
2014-11-26 14:17       ` Cornelia Huck
2014-11-26 14:24         ` Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 26/42] vhost/net: force len for TX to host endian Michael S. Tsirkin
2014-11-26 14:31   ` Cornelia Huck
2014-11-26 14:44     ` Michael S. Tsirkin
2014-11-26 14:54       ` Cornelia Huck
2014-11-26 15:01         ` Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 27/42] vhost: virtio 1.0 endian-ness support Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 28/42] vhost: make features 64 bit Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 29/42] vhost/net: virtio 1.0 byte swap Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 30/42] vhost/net: larger header for virtio 1.0 Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 31/42] vhost/net: enable " Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 32/42] vhost/net: suppress compiler warning Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 33/42] tun: move internal flag defines out of uapi Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 34/42] tun: drop most type defines Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 35/42] tun: add VNET_LE flag Michael S. Tsirkin
2014-11-25 16:43 ` [PATCH v4 36/42] tun: TUN_VNET_LE support, fix sparse warnings for virtio headers Michael S. Tsirkin
2014-11-25 16:44 ` [PATCH v4 37/42] macvtap: TUN_VNET_HDR support Michael S. Tsirkin
2014-11-25 16:44 ` [PATCH v4 38/42] virtio_scsi: v1.0 support Michael S. Tsirkin
2014-11-26 14:51   ` Cornelia Huck
2014-11-26 14:56     ` Michael S. Tsirkin
2014-11-25 16:44 ` [PATCH v4 39/42] virtio_scsi: move to uapi Michael S. Tsirkin
2014-11-25 16:44 ` Michael S. Tsirkin [this message]
2014-11-25 16:44 ` [PATCH v4 41/42] vhost/scsi: partial virtio 1.0 support Michael S. Tsirkin
2014-11-25 16:44 ` [PATCH v4 42/42] af_packet: virtio 1.0 stubs Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416933600-21398-41-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=agrover@redhat.com \
    --cc=anup.patel@linaro.org \
    --cc=ast@plumgrid.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=davem@davemloft.net \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=pbonzini@redhat.com \
    --cc=piotr.krol@3mdeb.com \
    --cc=rusty@au1.ibm.com \
    --cc=rusty@rustcorp.com.au \
    --cc=sakari.ailus@linux.intel.com \
    --cc=stephen@networkplumber.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome