mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chang Rebecca Swee Fun <rebecca.swee.fun.chang@intel.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: GPIO Subsystem Mailing List <linux-gpio@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Mika Westerberg <mika.westerberg@intel.com>,
	Denis Turischev <denis.turischev@compulab.co.il>,
	Alexandre Courbot <gnurou@gmail.com>
Subject: [PATCHv4 0/3] Enable Quark X1000 support in gpio-sch
Date: Wed, 26 Nov 2014 12:47:57 +0800	[thread overview]
Message-ID: <1416977280-27319-1-git-send-email-rebecca.swee.fun.chang@intel.com> (raw)

Hi all,

This is a revised version for enabling Quark X1000 support in gpio-sch.
This version of patch series had changed according to the feedback provided
by Alexandre and Mika.

Change log for V4:
Patch 1:
- Removed redundant/duplicated functions of sch_gpio_register_set() and
  sch_gpio_register_clear(). The function call had been replaced by
  sch_gpio_reg_set(gc, gpio, reg, 1) in place of sch_gpio_register_set() and
  sch_gpio_reg_set(gc, gpio, reg, 0) for sch_gpio_register_clear().
- Resolved double spinlock issue caught by Alexandre.

Patch 3:
- Dropped the usage of "if" block that checking irq_data struct
- Restructured the irq detect by using platform_get_irq(pdev, 0) instead of
  platform_get_resource(pdev, IORESOURCE_IRQ, 0) to get IRQ resources from
  MFD LPS-SCH.

The patches need to be patched on top of Mika Westerberg's commit at:
gpio: sch: Consolidate core and resume banks
http://marc.info/?l=linux-kernel&m=141392647225885&w=2

The patches has been verifed and tested working on Galileo Board. GPIO sysfs
was able to export gpio pins and changing pin direction. GPIO values were
able to controlled and interrupt was enabled.

Please help to review the patches so that we can make it to upstream kernel
as soon as possible. Thanks for all the review comments during this period of
review cycle.

Regards,
Rebecca

Change log for V3:
Patch 3:
- Change variable type of irq_support to bool.
- Update error message and remove redundant code.
- Revert gpiochip_remove() to avoid it to return a value.

Change log for V2:
Patch 1:
- Move sch_gpio_get() and sch_gpio_set() to avoid forward declaration.
- Changed sch_gpio_enable()/sch_gpio_disable() to sch_gpio_register_set()/
  sch_gpio_register_clear().

Patch 3:
- Changed all sch_gpio_enable()/sch_gpio_disable() to sch_gpio_register_set()/
  sch_gpio_register_clear().

Version 1:
Initial version.

Chang Rebecca Swee Fun (3):
  gpio: sch: Consolidate similar algorithms
  gpio: sch: Add support for Intel Quark X1000 SoC
  gpio: sch: Enable IRQ support for Quark X1000

 drivers/gpio/Kconfig    |   11 +-
 drivers/gpio/gpio-sch.c |  316 ++++++++++++++++++++++++++++++++++++++---------
 2 files changed, 266 insertions(+), 61 deletions(-)

-- 
1.7.9.5


             reply	other threads:[~2014-11-26  4:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-26  4:47 Chang Rebecca Swee Fun [this message]
2014-11-26  4:47 ` [PATCHv4 1/3] gpio: sch: Consolidate similar algorithms Chang Rebecca Swee Fun
2014-11-28 10:54   ` Mika Westerberg
2014-11-28 13:54   ` Linus Walleij
2014-11-28 13:57     ` Linus Walleij
2014-12-04  8:43   ` Alexandre Courbot
2014-11-26  4:47 ` [PATCHv4 2/3] gpio: sch: Add support for Intel Quark X1000 SoC Chang Rebecca Swee Fun
2014-12-04  8:45   ` Alexandre Courbot
2014-11-26  4:48 ` [PATCHv4 3/3] gpio: sch: Enable IRQ support for Quark X1000 Chang Rebecca Swee Fun
2014-11-27 10:53   ` Andy Shevchenko
2014-11-28 11:05   ` Mika Westerberg
2014-11-28 14:02   ` Linus Walleij
2014-12-03  2:26     ` Chang, Rebecca Swee Fun
2014-12-04  8:47       ` Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416977280-27319-1-git-send-email-rebecca.swee.fun.chang@intel.com \
    --to=rebecca.swee.fun.chang@intel.com \
    --cc=denis.turischev@compulab.co.il \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®