mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fred <fred.chou.nd@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: fred.chou.nd@gmail.com
Subject: [PATCH] staging: rt8192u: fix sparse warnings in r8192U_core.c
Date: Fri, 28 Nov 2014 16:56:42 +0800	[thread overview]
Message-ID: <1417165002-20030-1-git-send-email-fred.chou.nd@gmail.com> (raw)

Fixed the following warnings in sparse:
drivers/staging/rtl8192u/r8192U_core.c:670:6: warning:
 	symbol 'dump_eprom' was not declared.
	Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning:
 	symbol 'ComputeTxTime' was not declared.
	Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:1556:14: warning:
	symbol 'txqueue2outpipe' was not declared.
	Should it be static?
drivers/staging/rtl8192u/r8192U_core.c:4876:5: warning:
	symbol 'GetRxPacketShiftBytes819xUsb' was not declared.
	Should it be static?

Signed-off-by: Fred Chou <fred.chou.nd@gmail.com>
---
 drivers/staging/rtl8192u/r8192U_core.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
index 7640386..6b647ad 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -667,7 +667,7 @@ static void tx_timeout(struct net_device *dev)
 
 
 /* this is only for debug */
-void dump_eprom(struct net_device *dev)
+static void dump_eprom(struct net_device *dev)
 {
 	int i;
 	for (i = 0; i < 63; i++)
@@ -1486,7 +1486,7 @@ inline u8 rtl8192_IsWirelessBMode(u16 rate)
 
 u16 N_DBPSOfRate(u16 DataRate);
 
-u16 ComputeTxTime(u16 FrameLength, u16 DataRate, u8 bManagementFrame,
+static u16 ComputeTxTime(u16 FrameLength, u16 DataRate, u8 bManagementFrame,
 		  u8 bShortPreamble)
 {
 	u16	FrameTime;
@@ -1553,7 +1553,8 @@ u16 N_DBPSOfRate(u16 DataRate)
 	return N_DBPS;
 }
 
-unsigned int txqueue2outpipe(struct r8192_priv *priv, unsigned int tx_queue)
+static unsigned int txqueue2outpipe(struct r8192_priv *priv,
+						unsigned int tx_queue)
 {
 	if (tx_queue >= 9) {
 		RT_TRACE(COMP_ERR, "%s():Unknown queue ID!!!\n", __func__);
@@ -4873,7 +4874,8 @@ static void query_rxdesc_status(struct sk_buff *skb,
 
 }
 
-u32 GetRxPacketShiftBytes819xUsb(struct ieee80211_rx_stats  *Status, bool bIsRxAggrSubframe)
+static u32 GetRxPacketShiftBytes819xUsb(struct ieee80211_rx_stats  *Status,
+						bool bIsRxAggrSubframe)
 {
 #ifdef USB_RX_AGGREGATION_SUPPORT
 	if (bIsRxAggrSubframe)
-- 
1.9.1


             reply	other threads:[~2014-11-28  8:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-28  8:56 Fred [this message]
2014-12-01  1:54 Fred
2014-12-03  0:54 ` Greg KH
2014-12-03  2:31 Fred Chou
2014-12-03  3:51 ` Greg KH
2014-12-03  2:38 Fred Chou
2014-12-03  5:54 ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417165002-20030-1-git-send-email-fred.chou.nd@gmail.com \
    --to=fred.chou.nd@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®