mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Andrew Morton <akpm@linux-foundation.org>, Jan Kara <jack@suse.cz>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 7/7] lib: bitmap: Remove redundant code from __bitmap_shift_left
Date: Fri, 28 Nov 2014 17:01:10 +0100	[thread overview]
Message-ID: <1417190476-18066-8-git-send-email-linux@rasmusvillemoes.dk> (raw)
In-Reply-To: <1417190476-18066-1-git-send-email-linux@rasmusvillemoes.dk>

The first of these conditionals is completely redundant: If k ==
lim-1, we must have off==0, so the second conditional will also
trigger and then it wouldn't matter if upper had some high bits
set. But the second conditional is in fact also redundant, since it
only serves to clear out some high-order "don't care" bits of dst,
about which no guarantee is made.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
 lib/bitmap.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/lib/bitmap.c b/lib/bitmap.c
index 2362601..acea8ae 100644
--- a/lib/bitmap.c
+++ b/lib/bitmap.c
@@ -157,7 +157,7 @@ void __bitmap_shift_left(unsigned long *dst, const unsigned long *src,
 			unsigned int shift, unsigned int nbits)
 {
 	int k;
-	unsigned int lim = BITS_TO_LONGS(nbits), left = nbits % BITS_PER_LONG;
+	unsigned int lim = BITS_TO_LONGS(nbits);
 	unsigned int off = shift/BITS_PER_LONG, rem = shift % BITS_PER_LONG;
 	for (k = lim - off - 1; k >= 0; --k) {
 		unsigned long upper, lower;
@@ -170,13 +170,8 @@ void __bitmap_shift_left(unsigned long *dst, const unsigned long *src,
 			lower = src[k - 1] >> (BITS_PER_LONG - rem);
 		else
 			lower = 0;
-		upper = src[k];
-		if (left && k == lim - 1)
-			upper &= (1UL << left) - 1;
-		upper <<= rem;
+		upper = src[k] << rem;
 		dst[k + off] = lower | upper;
-		if (left && k + off == lim - 1)
-			dst[k + off] &= (1UL << left) - 1;
 	}
 	if (off)
 		memset(dst, 0, off*sizeof(unsigned long));
-- 
2.0.4


      parent reply	other threads:[~2014-11-28 16:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-28 16:01 [PATCH 0/7] lib: bitmap: Simplify bitmap_shift_{left,right} Rasmus Villemoes
2014-11-28 16:01 ` [PATCH 1/7] lib: bitmap: Change bitmap_shift_right to take unsigned parameters Rasmus Villemoes
2014-11-28 16:01 ` [PATCH 2/7] lib: bitmap: Eliminate branch in __bitmap_shift_right Rasmus Villemoes
2014-11-28 16:01 ` [PATCH 3/7] lib: bitmap: Remove redundant code from __bitmap_shift_right Rasmus Villemoes
2014-11-28 16:01 ` [PATCH 4/7] lib: bitmap: Yet another simplification in __bitmap_shift_right Rasmus Villemoes
2014-11-28 16:01 ` [PATCH 5/7] lib: bitmap: Change bitmap_shift_left to take unsigned parameters Rasmus Villemoes
2014-11-28 16:01 ` [PATCH 6/7] lib: bitmap: Eliminate branch in __bitmap_shift_left Rasmus Villemoes
2014-11-28 16:01 ` Rasmus Villemoes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417190476-18066-8-git-send-email-linux@rasmusvillemoes.dk \
    --to=linux@rasmusvillemoes.dk \
    --cc=akpm@linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®