From: Giedrius Statkevicius <giedriuswork@gmail.com>
To: dvhart@infradead.org
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
Giedrius Statkevicius <giedriuswork@gmail.com>
Subject: [PATCH] platform: x86: hp_wireless: Inform the user if hp_wireless_input_setup()/add() fails
Date: Sat, 29 Nov 2014 00:14:27 +0200 [thread overview]
Message-ID: <1417212867-25187-1-git-send-email-giedriuswork@gmail.com> (raw)
In hpwl_add() there is a unused variable err to which we assign the
result of hp_wireless_input_setup() but we don't do anything depending
on the result so print out a message that informs the user if add()
(hp_wireless_input_setup()) fails since acpi_device_probe() doesn't
print anything in this case.
Signed-off-by: Giedrius Statkevicius <giedriuswork@gmail.com>
---
drivers/platform/x86/hp-wireless.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/platform/x86/hp-wireless.c b/drivers/platform/x86/hp-wireless.c
index 415348f..4e4cc8b 100644
--- a/drivers/platform/x86/hp-wireless.c
+++ b/drivers/platform/x86/hp-wireless.c
@@ -85,6 +85,9 @@ static int hpwl_add(struct acpi_device *device)
int err;
err = hp_wireless_input_setup();
+ if (err)
+ pr_err("Failed to setup hp wireless hotkeys\n");
+
return err;
}
--
2.1.3
next reply other threads:[~2014-11-28 22:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 22:14 Giedrius Statkevicius [this message]
2014-11-28 23:15 ` Borislav Petkov
2014-11-28 23:48 ` Giedrius Statkevicius
2014-11-29 0:04 ` Borislav Petkov
2014-11-25 22:57 ` Darren Hart
2014-12-02 16:15 ` Giedrius Statkevicius
2014-12-02 17:19 ` Darren Hart
2014-12-01 7:22 ` Alex Hung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417212867-25187-1-git-send-email-giedriuswork@gmail.com \
--to=giedriuswork@gmail.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome