From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752636AbaLAFf1 (ORCPT ); Mon, 1 Dec 2014 00:35:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54501 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752589AbaLAFfZ (ORCPT ); Mon, 1 Dec 2014 00:35:25 -0500 Date: Mon, 01 Dec 2014 05:43:15 +0008 From: Jason Wang Subject: Re: [PATCH net-next V3] tun/macvtap: use consume_skb() instead of kfree_skb() when needed To: David Miller Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mst@redhat.com, eric.dumazet@gmail.com Message-Id: <1417412115.7521.2@smtp.corp.redhat.com> In-Reply-To: <20141129.210350.1994537005887744173.davem@davemloft.net> References: <1417070166-7026-1-git-send-email-jasowang@redhat.com> <20141129.210350.1994537005887744173.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 30, 2014 at 1:03 PM, David Miller wrote: > From: Jason Wang > Date: Thu, 27 Nov 2014 14:36:06 +0800 > >> To be more friendly with drop monitor, we should only call >> kfree_skb() when >> the packets were dropped and use consume_skb() in other cases. >> >> Cc: Eric Dumazet >> Signed-off-by: Jason Wang >> --- >> Changes from V2: >> - use unlikely() when necessary >> Changes from V1: >> - check the return value of tun/macvtap_put_user() > > This does not apply cleanly to net-next and will thus need to > be respun, thanks. Will post V3. Thanks