mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kan Liang <kan.liang@intel.com>
To: acme@kernel.org, jolsa@redhat.com, namhyung@kernel.org
Cc: linux-kernel@vger.kernel.org, ak@linux.intel.com,
	Kan Liang <kan.liang@intel.com>
Subject: [PATCH V6 2/3] perf tool: new function to compare common part of build-ids
Date: Mon,  1 Dec 2014 09:40:11 -0500	[thread overview]
Message-ID: <1417444812-22063-2-git-send-email-kan.liang@intel.com> (raw)
In-Reply-To: <1417444812-22063-1-git-send-email-kan.liang@intel.com>

From: Kan Liang <kan.liang@intel.com>

New function to compare the build_ids between different DSOs
This function is only interested in the common part of build_ids.
For example, dsos_a includes DSO A and DSO B. dsos_b includes DSO B and
DSO C. Only DSO B's build_id will be compared.

Signed-off-by: Kan Liang <kan.liang@intel.com>
---

Changes since V5:
 - Replace Arnaldo's dsos__build_ids_equal by bool dsos__build_ids_common_equal
 - Only compare the common part of build-ids

 tools/perf/util/dso.c | 20 ++++++++++++++++++++
 tools/perf/util/dso.h |  2 ++
 2 files changed, 22 insertions(+)

diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
index 45be944..04416b9 100644
--- a/tools/perf/util/dso.c
+++ b/tools/perf/util/dso.c
@@ -1087,3 +1087,23 @@ enum dso_type dso__type(struct dso *dso, struct machine *machine)
 
 	return dso__type_fd(fd);
 }
+
+bool dsos__build_ids_common_equal(struct dsos *dsos_a, struct dsos *dsos_b)
+{
+	struct dso *dso_a, *dso_b;
+
+	list_for_each_entry(dso_a, &dsos_a->head, node) {
+		dso_b = dsos__find(dsos_b, dso_a->short_name, true);
+		if (dso_b == NULL)
+			continue;
+		/*
+		 * Only compare the common part of dsos.
+		 */
+		if (dso_a->has_build_id && dso_b->has_build_id) {
+			if (memcmp(dso_a->build_id, dso_b->build_id, sizeof(dso_a->build_id)))
+				return false;
+		}
+	}
+
+	return true;
+}
diff --git a/tools/perf/util/dso.h b/tools/perf/util/dso.h
index 3782c82..e92217c 100644
--- a/tools/perf/util/dso.h
+++ b/tools/perf/util/dso.h
@@ -278,4 +278,6 @@ void dso__free_a2l(struct dso *dso);
 
 enum dso_type dso__type(struct dso *dso, struct machine *machine);
 
+bool dsos__build_ids_common_equal(struct dsos *dsos_a, struct dsos *dsos_b);
+
 #endif /* __PERF_DSO */
-- 
1.8.3.2


  reply	other threads:[~2014-12-01 15:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-01 14:40 [PATCH V6 1/3] perf tool: Add sort key symoff for perf diff Kan Liang
2014-12-01 14:40 ` Kan Liang [this message]
2014-12-01 14:40 ` [PATCH V6 3/3] perf tool: check buildid for symoff Kan Liang
2014-12-01 19:53 ` [PATCH V6 1/3] perf tool: Add sort key symoff for perf diff Jiri Olsa
2014-12-01 20:05   ` Liang, Kan
2014-12-01 20:18     ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417444812-22063-2-git-send-email-kan.liang@intel.com \
    --to=kan.liang@intel.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome