From: Grygorii Strashko <grygorii.strashko@ti.com>
To: "Wolfram Sang" <wsa@the-dreams.de>,
"Sekhar Nori" <nsekhar@ti.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: <linux-i2c@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Murali Karicheri <m-karicheri2@ti.com>
Subject: [PATCH v3 1/5] i2c: i2c-davinci: switch to use platform_get_irq
Date: Mon, 1 Dec 2014 17:34:03 +0200 [thread overview]
Message-ID: <1417448047-15236-2-git-send-email-grygorii.strashko@ti.com> (raw)
In-Reply-To: <1417448047-15236-1-git-send-email-grygorii.strashko@ti.com>
Switch Davinci I2C driver to use platform_get_irq(), because
it is not recommened to use platform_get_resource(pdev, IORESOURCE_IRQ, ..)
for requesting IRQ resources any more, as they can be not ready yet
in case of DT-boot.
CC: Sekhar Nori <nsekhar@ti.com>
CC: Kevin Hilman <khilman@deeprootsystems.com>
CC: Santosh Shilimkar <ssantosh@kernel.org>
CC: Murali Karicheri <m-karicheri2@ti.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
drivers/i2c/busses/i2c-davinci.c | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
index 4d96147..25e8e25 100644
--- a/drivers/i2c/busses/i2c-davinci.c
+++ b/drivers/i2c/busses/i2c-davinci.c
@@ -640,13 +640,17 @@ static int davinci_i2c_probe(struct platform_device *pdev)
{
struct davinci_i2c_dev *dev;
struct i2c_adapter *adap;
- struct resource *mem, *irq;
- int r;
-
- irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
- if (!irq) {
- dev_err(&pdev->dev, "no irq resource?\n");
- return -ENODEV;
+ struct resource *mem;
+ int r, irq;
+
+ irq = platform_get_irq(pdev, 0);
+ if (irq <= 0) {
+ if (!irq)
+ irq = -ENXIO;
+ if (irq != -EPROBE_DEFER)
+ dev_err(&pdev->dev,
+ "can't get irq resource ret=%d\n", irq);
+ return irq;
}
dev = devm_kzalloc(&pdev->dev, sizeof(struct davinci_i2c_dev),
@@ -661,7 +665,7 @@ static int davinci_i2c_probe(struct platform_device *pdev)
init_completion(&dev->xfr_complete);
#endif
dev->dev = &pdev->dev;
- dev->irq = irq->start;
+ dev->irq = irq;
dev->pdata = dev_get_platdata(&pdev->dev);
platform_set_drvdata(pdev, dev);
--
1.9.1
next prev parent reply other threads:[~2014-12-01 15:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 15:34 [PATCH v3 0/5] i2c: davinci improvements and fixes Grygorii Strashko
2014-12-01 15:34 ` Grygorii Strashko [this message]
2014-12-04 18:28 ` [PATCH v3 1/5] i2c: i2c-davinci: switch to use platform_get_irq Wolfram Sang
2014-12-01 15:34 ` [PATCH v3 2/5] i2c: davinci: generate STP always when NACK is received Grygorii Strashko
2014-12-04 18:28 ` Wolfram Sang
2014-12-01 15:34 ` [PATCH v3 3/5] i2c: recovery: change input parameter to i2c_adapter for prepare/unprepare_recovery Grygorii Strashko
2014-12-04 18:29 ` Wolfram Sang
2015-03-05 18:41 ` Grygorii Strashko
2015-03-12 11:32 ` Alexander Sverdlin
2015-03-13 10:15 ` Grygorii.Strashko@linaro.org
2015-03-13 15:45 ` Felipe Balbi
2014-12-01 15:34 ` [PATCH v3 4/5] i2c: davinci: use bus recovery infrastructure Grygorii Strashko
2015-03-12 11:45 ` Alexander Sverdlin
2015-03-18 20:31 ` Wolfram Sang
2015-03-20 18:32 ` Grygorii.Strashko@linaro.org
2015-04-03 20:18 ` Wolfram Sang
2015-04-06 13:11 ` Grygorii.Strashko@linaro.org
2015-04-06 16:09 ` Wolfram Sang
2015-04-06 16:28 ` Grygorii.Strashko@linaro.org
2014-12-01 15:34 ` [PATCH 5/5] i2c: davinci: use ICPFUNC to toggle I2C as gpio for bus recovery Grygorii Strashko
2015-04-01 14:38 ` Alexander Sverdlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417448047-15236-2-git-send-email-grygorii.strashko@ti.com \
--to=grygorii.strashko@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=nsekhar@ti.com \
--cc=ssantosh@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®